This repository was archived by the owner on Dec 10, 2025. It is now read-only.
Conversation
…locks better This is a side-effect of our effort to reduce provider size from blowing up. We use a skip list to ignore a very small number of attributes that are known to bloat the size of the provider significantly. This doesn't cause a problem for our JSON synthesis, since it doesn't care too much about types, but the HCL synthesis is more sensitive. This commit, while not fixing the problem, will do two things. First, it tries its best to output the attribute contents, and secondly, lets the user know this is a problem and one that they might want to fix either manually, or just use JSON output
DanielMSchmidt
approved these changes
May 22, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3630 (Partially)
Description
This is a side-effect of our effort to reduce provider size from blowing up. We use a skip list to ignore a very small number of attributes that are known to bloat the size of the provider significantly.
This doesn't cause a problem for our JSON synthesis, since it doesn't care too much about types, but the HCL synthesis is more sensitive.
This commit, while not fixing the problem, will do two things. First, it tries its best to output the attribute contents, and secondly, lets the user know this is a problem and one that they might want to fix either manually, or just use JSON output
It is important to note that this does not solve the issue completely, as the HCL output will probably not be usable directly without modification, but this is a best effort solution that leaves the developer in a slightly better state with more context. Until we get to a solution where skipping attributes is not needed, this will be the best solution.
Checklist