Conversation
bflad
reviewed
Nov 9, 2023
Contributor
bflad
left a comment
There was a problem hiding this comment.
Please reach out with any questions!
bflad
reviewed
Nov 10, 2023
Contributor
bflad
left a comment
There was a problem hiding this comment.
After this should be good to go!
bflad
approved these changes
Nov 15, 2023
| | `.ProviderName` | string | Canonical provider name (ex. `terraform-provider-random`) | | ||
| | `.ProviderShortName` | string | Short version of the provider name (ex. `random`) | | ||
| | `.RenderedProviderName` | string | Value provided via argument `--rendered-provider-name`, otherwise same as `.ProviderName` | | ||
| | `.SchemaMarkdown` | string | a Markdown formatted Provider Schema definition | |
| | `lower` | Equivalent to [`strings.ToLower`](https://pkg.go.dev/strings#ToLower). | | ||
| | `plainmarkdown` | Render Markdown content as plaintext. | | ||
| | `prefixlines` | Add a prefix to all (newline-separated) lines in a string. | | ||
| | `printf` | Equivalent to [`fmt.Printf`](https://pkg.go.dev/fmt#Printf). | |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testscriptacceptance tests fortfplugindocs generatesubcommand:no such file or directoryerrors in cleaning rendered website directory: the acceptance tests revealed a bug introduced in generate: Remove onlytfplugindocsmanaged files and subdirectories from rendered website directory #267 where providers with no existing docs would return early with an error when deleting the rendered website directory before generation.This PR includes a fix to ignore that specific error and not return early.
resourceTemplate.RenderandproviderTemplate.Render