Add support for --provider-schema flag and context to generate sub-command errors#299
Merged
Add support for --provider-schema flag and context to generate sub-command errors#299
--provider-schema flag and context to generate sub-command errors#299Conversation
… as a parameter.
… separate folder.
bflad
approved these changes
Nov 20, 2023
Contributor
bflad
left a comment
bflad
left a comment
There was a problem hiding this comment.
Looks good to me 🚀 Super awesome. Just some minor wording suggestions to clarify "schema generation" to mean building the provider and calling Terraform CLI.
| g.websiteTmpDir, err = os.MkdirTemp("", "tfws") | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("error creating temporary website directory: %w", err) |
Co-authored-by: Brian Flad <bflad417@gmail.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
--provider-schemaargument to pass in a providers schema JSON file. This allowstfplugindocsto skip schema generation by building the provider and running theterraform providers schema -jsoncommand.schema-jsontests equivalents to existing acceptance testsg.providerNameinstead of passing provider name in as a parametergenerate.goWhy?
The new flag simplifies acceptance testing writing and maintenance by eliminating the need include provider source code in
.txtarfiles.