Adding Set validation for SizeAtLeast, SizeAtMost and SizeBetween#40
Merged
bendbennett merged 11 commits intomainfrom Jun 23, 2022
Merged
Adding Set validation for SizeAtLeast, SizeAtMost and SizeBetween#40bendbennett merged 11 commits intomainfrom
bendbennett merged 11 commits intomainfrom
Conversation
Contributor
Author
|
Following discussion with @detro we could consolidate the |
bflad
approved these changes
Jun 22, 2022
Contributor
bflad
left a comment
bflad
left a comment
There was a problem hiding this comment.
Other than missing Go documentation for provider developers and changelog entry, looks good to me 🚀
| } | ||
| } | ||
|
|
||
| func SizeAtLeast(min int) tfsdk.AttributeValidator { |
| } | ||
| } | ||
|
|
||
| func SizeAtMost(max int) tfsdk.AttributeValidator { |
| } | ||
| } | ||
|
|
||
| func SizeBetween(min, max int) tfsdk.AttributeValidator { |
bendbennett
force-pushed
the
bendbennett/issues-5
branch
from
77c0a76 to
2e2bc0c
Compare
bendbennett
force-pushed
the
bendbennett/issues-12
branch
from
2013d59 to
d106fc2
Compare
bendbennett
force-pushed
the
bendbennett/issues-5
branch
from
2e2bc0c to
375b34d
Compare
bendbennett
force-pushed
the
bendbennett/issues-5
branch
from
375b34d to
e71aeef
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5