Skip to content

tfprotov6: Add protocol support for pluggable state storage#563

Merged
austinvalle merged 19 commits intomainfrom
f-pluggable-state-store
Jan 16, 2026
Merged

tfprotov6: Add protocol support for pluggable state storage#563
austinvalle merged 19 commits intomainfrom
f-pluggable-state-store

Conversation

@radeksimko
Copy link
Copy Markdown
Member

@radeksimko radeksimko commented Sep 18, 2025

Maintainer note from @austinvalle 👋🏻

After discussion offline, this PR is in a good place to be merged now, and all review feedback are small naming adjustments / unit tests / etc, which I will be opening a follow-up PR to reflect.

This PR introduces the protocol (v6 only) for providers to support Pluggable State Storage (PSS), which will be represented as the state_store type in configurations. The corresponding changes for PSS support are still on-going across a couple repositories so it's possible these types/names/rpc methods could change prior to a stable release of this Go module.

@radeksimko radeksimko force-pushed the f-pluggable-state-store branch from f97369d to cb07eb7 Compare September 18, 2025 14:05
Comment thread tfprotov6/tf6server/server.go
@SarahFrench
Copy link
Copy Markdown
Member

@radeksimko FYI if you rebase this branch on main it'll pull in changes to how we use protoc, so you can use make protobuf in this repo and in hashicorp/terraform when working on both sides of the protocol changes

@radeksimko radeksimko force-pushed the f-pluggable-state-store branch 2 times, most recently from 9b025af to fca79ea Compare September 25, 2025 13:45
@SarahFrench SarahFrench force-pushed the f-pluggable-state-store branch from 5cb68b8 to b0e5c5f Compare October 28, 2025 09:20
@SarahFrench
Copy link
Copy Markdown
Member

Addressed issues with codegen by rebasing onto main

@SarahFrench
Copy link
Copy Markdown
Member

SarahFrench commented Nov 6, 2025

Something I've realised is missing when adding some E2E tests today - we need to add support for LockState/UnlockState in tfprotov6/tf6server/server.go
(And implementation in state_store.go)

@austinvalle austinvalle force-pushed the f-pluggable-state-store branch from 331187d to e3a0762 Compare January 12, 2026 22:04
@austinvalle austinvalle marked this pull request as ready for review January 15, 2026 21:02
@austinvalle austinvalle requested a review from a team as a code owner January 15, 2026 21:02
@austinvalle austinvalle changed the title [DRAFT] Support for PSS tfprotov6: Add protocol support for pluggable state storage Jan 15, 2026
@austinvalle austinvalle added this to the v0.30.0 milestone Jan 15, 2026
@austinvalle austinvalle added the enhancement New feature or request label Jan 15, 2026
Copy link
Copy Markdown
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, I updated the PR description + title, but all review feedback I have are minimal naming/tests/logging related, which I will handle in a follow-up PR.

@austinvalle austinvalle merged commit dfb1155 into main Jan 16, 2026
108 checks passed
@austinvalle austinvalle deleted the f-pluggable-state-store branch January 16, 2026 13:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants