tflog+tfsdklog: Add root and subsystem unit testing#33
Merged
Conversation
Reference: #31 Backfill unit testing for the following functions: - `With()` / `SubsystemWith()` - `Trace()`/ `SubsystemTrace()` - `Debug()`/ `SubsystemDebug()` - `Info()`/ `SubsystemInfo()` - `Warn()`/ `SubsystemWarn()` - `Error()`/ `SubsystemError()`
detro
approved these changes
Feb 25, 2022
Contributor
detro
left a comment
detro
left a comment
There was a problem hiding this comment.
LGTM
Very thorough: I have rarely seen testing a logging system, for each combination.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #31
Backfill unit testing for the following functions:
With()/SubsystemWith()Trace()/SubsystemTrace()Debug()/SubsystemDebug()Info()/SubsystemInfo()Warn()/SubsystemWarn()Error()/SubsystemError()In preparation for potential updates to the function signatures to prevent
EXTRA_VALUE_AT_ENDin log entries.