Trying pull_request_target trigger event for add-content-to-project workflow#39
Merged
Trying pull_request_target trigger event for add-content-to-project workflow#39
pull_request_target trigger event for add-content-to-project workflow#39Conversation
bflad
approved these changes
Mar 9, 2022
This was referenced Mar 10, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching the event used by
add-content-to-projectGH Action, in case of Pull Requests.It turns out,
pull_request_targetis the only trigger that can be used that ALSO has access tosecretsof the project.But the key implication is to use it EXCLUSIVELY for actions that do not use anything from the triggering PR (like in this case), otherwise there is a very high risk of leaking secrets.