resource/route53_zone and data-source/route53_zone: remove trailing period from name attributes by anGie44 · Pull Request #14220 · hashicorp/terraform-provider-aws

anGie44 · 2020-07-16T22:36:53Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13510
Closes #13010
Closes #7501
Closes #7800
Closes #6389
Closes #241
Related #1031

Release note for CHANGELOG:

service/route53: remove trailing period from name attributes in zone resource and data-source

Output from acceptance testing:

--- PASS: TestAccAWSRoute53Zone_basic (51.18s)
--- PASS: TestAccAWSRoute53Zone_multiple (53.74s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (46.19s)
--- PASS: TestAccAWSRoute53Zone_Comment (59.44s)
--- PASS: TestAccAWSRoute53Zone_disappears (41.69s)
--- PASS: TestAccAWSRoute53Zone_Tags (63.88s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (86.49s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (163.38s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (190.02s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (186.48s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (251.37s)

--- PASS: TestAccAWSRoute53ZoneAssociation_region (171.75s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (144.77s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (150.37s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (164.37s)
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (164.55s)

anGie44 · 2020-07-22T18:45:35Z

Note: The following PRs are contingent on these changes and should be merged into this branch first to verify all tests/files play nicely

resource/ses_domain_identity and resource/ses_domain_identity_verification: remove domain custom StateFunc #14301
resource/acm_certificate: remove custom StateFunc to handle domain_name trailing period #14300
resource/route53_resolver_rule and data-source/route53_resolver_rule: remove domain_name trailing period #14298
resource/route53_record: remove StateFunc handling of trailing period in name attribute #14297

bflad

Overall going in the right direction! We'll need to fix the CI errors before we can test this.

bflad

This is looking good! Let's bring in those other resource changes and we should be able to merge this in. 👍

author Brian Flad <bflad417@gmail.com> 1594769808 -0400 committer Angie Pinilla <angelinepinilla@gmail.com> 1595878294 -0400 parent b69af0579e0415631faa9b77559a55a5f6e7c208 author Brian Flad <bflad417@gmail.com> 1594769808 -0400 committer Angie Pinilla <angelinepinilla@gmail.com> 1595878093 -0400 tests/provider: Update testacc target to error when provided example test pattern (#14091) * tests/provider: Update testacc target to error when provided example test pattern Reference: https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/PULL_REQUEST_TEMPLATE.md The pull request template suggests an example of how to run acceptance testing, but uses a placeholder example since its not feasible to reliably determine this automatically via git, etc. Also given that we have begun adding many more Go packages beyond just the top level provider one, the output can look potentially valid when it really is not meaningful: ```console $ $ make testacc TESTARGS='-run=TestAccXXX' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccXXX -timeout 120m ? github.com/terraform-providers/terraform-provider-aws [no test files] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws 2.594s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap 0.409s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.792s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/naming 1.619s [no tests to run] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/waiter [no test files] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency 0.373s [no tests to run] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/waiter [no test files] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token 0.343s [no tests to run] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/guardduty/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/secretsmanager/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicediscovery/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sfn/waiter [no test files] ? github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/waiter [no test files] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/aws/internal/tfawsresource 1.022s [no tests to run] ? github.com/terraform-providers/terraform-provider-aws/awsproviderlint [no test files] ? github.com/terraform-providers/terraform-provider-aws/awsproviderlint/helper/awsprovidertype/keyvaluetags [no test files] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes 2.115s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT001 2.212s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSAT002 0.326s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR001 0.412s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/AWSR002 2.086s [no tests to run] testing: warning: no tests to run PASS ok github.com/terraform-providers/terraform-provider-aws/awsproviderlint/passes/fmtsprintfcallexpr 0.248s [no tests to run] ``` This now focuses the acceptance testing on the top level package to remove the extraneous package output and returns an error when attempting to use the example verbatim: ```console $ make testacc TESTARGS='-run=TestAccXXX' ==> Checking that code complies with gofmt requirements... Error: Skipping example acceptance testing pattern. Update TESTARGS to match the test naming in the relevant *_test.go file. For example if updating aws/resource_aws_acm_certificate.go, use the test names in aws/resource_aws_acm_certificate_test.go starting with TestAcc and up to the underscore: make testacc TESTARGS='-run=TestAccAWSAcmCertificate_' See the contributing guide for more information: https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/running-and-writing-acceptance-tests.md make: *** [testacc] Error 1 $ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAvailabilityZones_ -timeout 120m === RUN TestAccAWSAvailabilityZones_basic ... ``` * docs/provider: Remove TEST=./aws usage in running acceptance testing section resource/aws_s3_bucket: Convert region to read-only attribute (#14127) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/592 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/1656 Output from acceptance testing (NOTE: CUR data source and resource need to be tested in standalone account due to Organization permissions and appear to be failing due to new validation in the API that's not handled in the resource yet): ``` --- PASS: TestAccAWSS3Bucket_acceleration (65.86s) --- PASS: TestAccAWSS3Bucket_AclToGrant (67.94s) --- PASS: TestAccAWSS3Bucket_basic (37.25s) --- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (35.95s) --- PASS: TestAccAWSS3Bucket_Cors_Delete (31.78s) --- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (37.29s) --- PASS: TestAccAWSS3Bucket_Cors_Update (65.22s) --- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (62.31s) --- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (37.28s) --- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (43.14s) --- PASS: TestAccAWSS3Bucket_forceDestroy (31.61s) --- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (31.54s) --- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (37.95s) --- PASS: TestAccAWSS3Bucket_generatedName (35.53s) --- PASS: TestAccAWSS3Bucket_GrantToAcl (57.50s) --- PASS: TestAccAWSS3Bucket_LifecycleBasic (86.93s) --- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (62.03s) --- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (31.01s) --- PASS: TestAccAWSS3Bucket_Logging (55.35s) --- PASS: TestAccAWSS3Bucket_namePrefix (35.81s) --- PASS: TestAccAWSS3Bucket_objectLock (60.93s) --- PASS: TestAccAWSS3Bucket_Policy (88.67s) --- PASS: TestAccAWSS3Bucket_Replication (147.39s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (86.62s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (84.62s) --- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (28.14s) --- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (152.22s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (52.74s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (51.40s) --- PASS: TestAccAWSS3Bucket_RequestPayer (63.26s) --- PASS: TestAccAWSS3Bucket_shouldFailNotFound (15.41s) --- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (118.49s) --- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (163.94s) --- PASS: TestAccAWSS3Bucket_UpdateAcl (58.70s) --- PASS: TestAccAWSS3Bucket_UpdateGrant (91.75s) --- PASS: TestAccAWSS3Bucket_Versioning (90.14s) --- PASS: TestAccAWSS3Bucket_Website_Simple (89.22s) --- PASS: TestAccAWSS3Bucket_WebsiteRedirect (86.48s) --- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (63.97s) --- PASS: TestAccAWSSsmResourceDataSync_basic (15.77s) --- PASS: TestAccAWSSsmResourceDataSync_update (28.49s) TestAccAwsCurReportDefinition_basic: testing.go:684: Step 0 error: errors during apply: Error: Error creating AWS Cost And Usage Report Definition: ValidationException: Failed to verify customer bucket permission. accountId= --OMITTED--, bucket name: tf-test-bucket-3532084976228094739, bucket region: us-east-1 TestAccDataSourceAwsCurReportDefinition_basic: testing.go:684: Step 0 error: errors during apply: Error: Error creating AWS Cost And Usage Report Definition: ValidationException: Failed to verify customer bucket permission. accountId= --OMITTED--, bucket name: tf-test-bucket-9147728765044904331, bucket region: us-east-1 ``` Update CHANGELOG for #14127 Corrects name of Workspaces Workspace sweeper let subject_alternative_names be a set re-add computed: true to subject_alternative_names attribute resource/aws_acm_certificate: Finalize subject_alternative_names change from TypeList to TypeSet Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/11300 Output from acceptance testing: ``` --- PASS: TestAccAWSAcmCertificate_imported_IpAddress (11.98s) --- PASS: TestAccAWSAcmCertificate_wildcard (14.66s) --- PASS: TestAccAWSAcmCertificate_emailValidation (14.79s) --- PASS: TestAccAWSAcmCertificate_root (15.12s) --- PASS: TestAccAWSAcmCertificate_disableCTLogging (15.15s) --- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (15.80s) --- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (16.01s) --- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (16.44s) --- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (18.30s) --- PASS: TestAccAWSAcmCertificate_san_single (18.38s) --- PASS: TestAccAWSAcmCertificate_dnsValidation (18.62s) --- PASS: TestAccAWSAcmCertificate_san_multiple (19.06s) --- PASS: TestAccAWSAcmCertificate_privateCert (22.34s) --- PASS: TestAccAWSAcmCertificate_imported_DomainName (26.46s) --- PASS: TestAccAWSAcmCertificate_tags (37.20s) ``` Remove hardcoded AMI IDs from launch_config data source Removing import of aws_security_group_rule for rules associated with aws_security_group implicitly during its import. Acceptance tests updated to account for removed rules in import state check. rebased and addressed review feedback Update CHANGELOG for #12616 update documentation attributes add missing validation value for comparison_operator argument delete_on_termination on ENI has to be optional like the EBS delete_on_termination this can be optional and cannot be treated like a real bool but has to be treated as a string which can be empty or a bool representation testing all possible inputs now testing as well `delete_on_termination = ""` and `delete_on_termination = null` which both should not set the value to anything. adding upgrade instructions version 3 upgrade details Update CHANGELOG for #8612 add private_ips field change private_ips to secondary_private_ips and enable update update to using expandstringset method Update CHANGELOG for #14079 Removed hardcoded AMI IDs from AutoscalingAttachment docs/resource/aws_codebuild_webhook: Add COMMIT_MESSAGE to acceptable codebuild filter types (#14207) Co-authored-by: mikiya771 <norep> Fixes aws_lambda_alias import to set function_name attribute correctly instead of function's ARN resource/aws_lambda_alias: Finalize resource import adjustments Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/12876 Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaAlias_FunctionName_Name (35.53s) --- PASS: TestAccAWSLambdaAlias_basic (53.18s) --- PASS: TestAccAWSLambdaAlias_nameupdate (62.70s) --- PASS: TestAccAWSLambdaAlias_routingconfig (63.82s) ``` Update CHANGELOG for #12876 remove trailing period from domainname/name attributes update to using TrimSuffix strings method isolate changes to only route53_zone return error for singular data source Error when data.aws_ecr_repository cannot find repository Fixes https://github.com/terraform-providers/terraform-provider-aws/issues/10071. adjust error messaging return error for singular data source add angie and dirk consolidate maintainer lists Ignore hardcoded AMI because not actually used Add underscore to acceptance test names, minor naming convention fixes provider: Remove unnecessary fmt.Sprint()/fmt.Sprintf() (#14242) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/14239 Update Terraform github to v2.9.2 (#14021) * Update Terraform github to v2.9.2 * infrastructure/repository: Use organization argument instead of owner in github provider configuration Appears that the provider reverted the deprecation of the `organization` argument and inclusion of the new `owner` argument in 2.9.x, delaying until 3.0.0. Previously: ``` Error: Unsupported argument on main.tf line 14, in provider "github": 14: owner = "terraform-providers" An argument named "owner" is not expected here. ``` Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Brian Flad <bflad417@gmail.com> add-q3-roadmap-draft add old roadmap section fix milestone link remove currently in progress in case it causes confusion r/aws_apigatewayv2_integration: suppress diff for passthrough_behavior Update CHANGELOG for #13062 Update ROADMAP.md to fix formatting omissions docs/provider: Setup and document release/* branch convention, link 2.x and earlier changelog entries (#14177) * docs/provider: Setup and document release/* branch convention, link 2.x and earlier changelog entries Reference: https://github.com/terraform-providers/terraform-provider-aws/tree/release/2.x * tests/provider: Ensure release/* branches are ran on push via GitHub Actions docs/provider: Document max_retries default (#14256) adjust error formatting and handling tests/resource/aws_s3_bucket: Add S3 Same-Region Replication acceptance test (#10170) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (52.57s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (56.62s) ``` tests/resource/aws_rds_cluster: Remove aws_s3_bucket region argument from TestAccAWSRDSCluster_s3Restore (#14272) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14127 Missed during test configuration cleanup after the referenced argument removal. Fixes the initial configuration issue, but does not fix the (still) broken test which is presumably something to do with the backup file or engine version. Previously: ``` --- FAIL: TestAccAWSRDSCluster_s3Restore (0.99s) testing.go:684: Step 0 error: config is invalid: "region": this field cannot be set ``` Output from acceptance testing: ``` === CONT TestAccAWSRDSCluster_s3Restore TestAccAWSRDSCluster_s3Restore: testing.go:684: Step 0 error: errors during apply: Error: Error waiting for RDS Cluster state to be "available": unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>) ``` refactor resource import set virtual attributes in import func Update CHANGELOG for #10520 and #10521 update default value for min_capacity in scaling_configuration block of rds_cluster Update CHANGELOG for #14268 keep throttling disabled by default in api gateway method settings resource update import ID pattern Update CHANGELOG for #14266 add plan time validation to `self_managed_active_directory.dns_ips` add support for multi az deployment add deployment type to test add computed flag to deployment_type add docs fix docs remove computed fix multi az test disappears fix lint issue add support for `SINGLE_AZ_2` type Update website/docs/r/fsx_windows_file_system.html.markdown Co-authored-by: Simon Davis <simon@breathingdust.com> Update website/docs/r/fsx_windows_file_system.html.markdown Co-authored-by: Simon Davis <simon@breathingdust.com> Update website/docs/r/fsx_windows_file_system.html.markdown Co-authored-by: Simon Davis <simon@breathingdust.com> Update CHANGELOG.md for #12676 Fix schema set errors (#14167) * Fix schema set errors * Fix wrong attribute * Fix type * Flatten ssm parameters * resource/elasticsearch_domain: update method to set advanced_security_options (#14198) * set advanced security options only if enabled * refactor and set values depending on enabled field Co-authored-by: angie pinilla <angelinepinilla@gmail.com> tests/provider: Enable AWSAT004 check for CI (#14216) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14097 resource/aws_launch_configuration: Remove DescribeLaunchConfigurations retries on all errors (#14260) Reference: https://github.com/hashicorp/terraform/issues/302 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Does not seem to be occurring anymore, but could require additional load to manifest. Can re-add explicit retries as necessary. Output from acceptance testing: ``` --- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (11.31s) --- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (13.17s) --- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (13.44s) --- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (13.67s) --- PASS: TestAccAWSLaunchConfiguration_withEncryption (14.02s) --- PASS: TestAccAWSLaunchConfiguration_basic (22.34s) --- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (24.19s) --- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (25.59s) --- PASS: TestAccAWSLaunchConfiguration_userData (28.60s) --- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_VolumeSize (28.91s) --- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (30.96s) --- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (32.72s) --- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_AmiDisappears (353.93s) ``` resource/aws_spot_fleet_request: Only retry RequestSpotFleet on IAM eventual consistency errors, use standard 2 minute timeout (#14265) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/7740 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Output from acceptance testing: ``` --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (251.97s) --- PASS: TestAccAWSSpotFleetRequest_basic (314.23s) --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (612.33s) --- PASS: TestAccAWSSpotFleetRequest_disappears (261.47s) --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (403.92s) --- PASS: TestAccAWSSpotFleetRequest_fleetType (316.94s) --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (251.69s) --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (253.29s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (112.90s) --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (142.33s) --- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (467.97s) --- PASS: TestAccAWSSpotFleetRequest_launchTemplate (253.11s) --- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (254.84s) --- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (468.45s) --- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (253.43s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.51s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (314.01s) --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (276.90s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (486.46s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (406.36s) --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (231.26s) --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (295.29s) --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (57.48s) --- PASS: TestAccAWSSpotFleetRequest_tags (342.55s) --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (597.13s) --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (753.34s) --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (255.16s) --- PASS: TestAccAWSSpotFleetRequest_WithELBs (277.96s) --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (232.56s) --- PASS: TestAccAWSSpotFleetRequest_withTags (282.39s) --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (427.61s) --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (335.33s) ``` Update CHANGELOG for #14265 resource/aws_codepipeline: Only retry CreatePipeline errors for IAM eventual consistency (#14264) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Output from acceptance testing: ``` --- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (33.11s) --- PASS: TestAccAWSCodePipeline_WithNamespace (35.13s) --- PASS: TestAccAWSCodePipeline_multiregion_basic (36.83s) --- PASS: TestAccAWSCodePipeline_deployWithServiceRole (42.85s) --- PASS: TestAccAWSCodePipeline_basic (57.83s) --- PASS: TestAccAWSCodePipeline_multiregion_Update (61.32s) --- PASS: TestAccAWSCodePipeline_tags (76.28s) --- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (79.20s) ``` Update CHANGELOG for #14264 resource/aws_ssm_activation: Only retry CreateActivation on IAM eventual consistency error, allow retries for standard 2 minutes (#14263) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 API does not seem to validate IAM Role permissions on creation. Output from acceptance testing: ``` --- PASS: TestAccAWSSSMActivation_expirationDate (19.17s) --- PASS: TestAccAWSSSMActivation_disappears (25.22s) --- PASS: TestAccAWSSSMActivation_basic (27.39s) --- PASS: TestAccAWSSSMActivation_update (37.23s) ``` Update CHANGELOG for #14263 resource/aws_network_acl_rule: Immediately return DescribeNetworkAcls errors on creation (#14261) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Output from acceptance testing: ``` --- PASS: TestAccAWSNetworkAclRule_allProtocol (44.33s) --- PASS: TestAccAWSNetworkAclRule_basic (32.50s) --- PASS: TestAccAWSNetworkAclRule_disappears (32.83s) --- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (27.16s) --- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (30.24s) --- PASS: TestAccAWSNetworkAclRule_ipv6 (29.23s) --- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (28.65s) --- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (47.71s) --- PASS: TestAccAWSNetworkAclRule_missingParam (15.14s) --- PASS: TestAccAWSNetworkAclRule_tcpProtocol (40.32s) ``` Update CHANGELOG for #14261 Add function to check TypeSet pairs Add unit tests for TestCheckTypeSetElemAttrPair tests/resource/aws_rds_cluster: Fix TestAccAWSRDSCluster_EngineVersion (#14286) isolate changes to only route53_record resource update additional domian name example in upgrade guide Co-authored-by: Brian Flad <bflad417@gmail.com> update with CR comments isolate changes to only resolver rule isolate changes to only acm_certificate isolate changes to only ses_domain_identity re-add trailing period acctest merge with parent branch and update statefuncs to use global method update statefuncs to use global method and update tests w/trailingp period domains r/aws_apigatewayv2_stage: Make deployment_id a computed attribute. Update CHANGELOG.md for #13644 bump to go v1.14.5 r/aws_apigatewayv2_integration: Add 'request_parameters' attribute. Update CHANGELOG.md for #14080 r/aws_apigatewayv2_route: Update route key. Update CHANGELOG.md for #13833 Revert "Remove 'tls_config' attribute. It doesn't seem to do anything right now." This reverts commit ffbce32f931a9b33adc8407a267ba176c510bd44. r/aws_apigatewayv2_integration: Test HTTP API VPC Link integration. r/aws_apigatewayv2_integration: Additional import test step in 'TestAccAWSAPIGatewayV2Integration_VpcLinkHttp'. Update CHANGELOG.md Update CHANGELOG.md for #13013 Update CHANGELOG.md add atleastoneof property to filter attributes Update CHANGELOG for #14230 Remove hardcoded AMI and AZ Improve static check for hardcoded partition in ARN resource/aws_lambda_function: Increase IAM retry timeout for create to 2 minutes (#14291) References: * https://github.com/terraform-providers/terraform-provider-aws/issues/14285 Increased the retry timeout for eventual consistency IAM errors during a lambda function create from 1 minute to 2 minute. Output from acceptance testing: ``` make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaFunction_' ... --- PASS: TestAccAWSLambdaFunction_basic (28.86s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (34.46s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (160.32s) --- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (208.54s) --- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (567.54s) --- PASS: TestAccAWSLambdaFunction_VPCRemoval (596.13s) --- PASS: TestAccAWSLambdaFunction_LayersUpdate (49.02s) --- PASS: TestAccAWSLambdaFunction_VPC (362.84s) --- PASS: TestAccAWSLambdaFunction_VPCUpdate (797.25s) --- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (120.01s) --- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (51.30s) --- PASS: TestAccAWSLambdaFunction_envVariables (153.15s) --- PASS: TestAccAWSLambdaFunction_versioned (39.16s) --- PASS: TestAccAWSLambdaFunction_versionedUpdate (61.80s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (31.16s) --- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (51.77s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_dotnetcore31 (36.20s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (40.86s) --- PASS: TestAccAWSLambdaFunction_Layers (38.54s) --- PASS: TestAccAWSLambdaFunction_tracingConfig (51.87s) --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (36.57s) --- PASS: TestAccAWSLambdaFunction_concurrencyCycle (54.03s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (36.53s) --- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (13.34s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (28.27s) --- PASS: TestAccAWSLambdaFunction_tags (51.19s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (36.59s) --- PASS: TestAccAWSLambdaFunction_updateRuntime (51.42s) --- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (43.77s) --- PASS: TestAccAWSLambdaFunction_localUpdate (39.80s) --- PASS: TestAccAWSLambdaFunction_s3Update_basic (44.15s) --- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (40.02s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (32.09s) --- PASS: TestAccAWSLambdaFunction_FileSystemConfig (721.87s) --- PASS: TestAccAWSLambdaFunction_s3 (31.68s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (36.48s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (33.63s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (38.17s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.91s) --- PASS: TestAccAWSLambdaFunction_concurrency (46.63s) --- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (38.38s) --- PASS: TestAccAWSLambdaFunction_disappears (36.13s) --- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (38.47s) ``` Update CHANGELOG for #14291 error when iops provided for unsupported type improve upgrade docs for iops Update CHANGELOG for #14310 Update CHANGELOG with Go versioning Remove hardcoded AMIs and AZs Remove hardcoded AMIs and AZs Removed hardcoded AMIs and AZs Remove hardcoded AMI and AZ Remove hardcoded AMI r/aws_apigatewayv2_stage: 'data_trace_enabled' and 'logging_level' are only valid for WebSocket APIs. r/aws_apigatewayv2_stage: No need for diff-suppression for new resources. r/aws_apigatewayv2_stage: Additional route_settings and default_route_settings test cases. r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' attribute. r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenApiGatewayV2RouteSettings'. Revert "r/aws_apigatewayv2_stage: Pass API protocol type to 'flattenApiGatewayV2RouteSettings'." This reverts commit 9337272b7842879cdbae5be19ec076bea314b20c. Revert "r/aws_apigatewayv2_stage: Add computed 'api_protocol_type' attribute." This reverts commit a7eb7cf9976ecabb04696dbe2f39805cc0ec1401. Fix mess from rebase. r/aws_apigatewayv2_stage: Change 'route_setting.logging_level' to computed to address different defaults for WebSocket vs. HTTP. Update CHANGELOG.md for #13809 resource/aws_acm_certificate: Convert domain_validation_options to TypeSet and calculate elements during plan (#14199) * resource/aws_acm_certificate: Convert domain_validation_options to TypeSet and calculate elements during plan Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8531 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10098 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/10404 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13053 Output from acceptance testing: ``` --- PASS: TestAccAWSAcmCertificate_imported_IpAddress (11.48s) --- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (15.53s) --- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (15.53s) --- PASS: TestAccAWSAcmCertificate_root (15.62s) --- PASS: TestAccAWSAcmCertificate_emailValidation (15.91s) --- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (16.38s) --- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (16.43s) --- PASS: TestAccAWSAcmCertificate_san_single (16.51s) --- PASS: TestAccAWSAcmCertificate_dnsValidation (16.85s) --- PASS: TestAccAWSAcmCertificate_disableCTLogging (17.06s) --- PASS: TestAccAWSAcmCertificate_wildcard (18.71s) --- PASS: TestAccAWSAcmCertificate_san_multiple (19.49s) --- PASS: TestAccAWSAcmCertificate_privateCert (20.85s) --- PASS: TestAccAWSAcmCertificate_imported_DomainName (26.86s) --- PASS: TestAccAWSAcmCertificate_tags (42.99s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (11.56s) --- PASS: TestAccAWSAcmCertificateValidation_timeout (19.20s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (107.31s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (110.62s) --- PASS: TestAccAWSAcmCertificateValidation_basic (143.58s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (153.05s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (212.21s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (212.95s) --- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (247.43s) ``` Please note that this was also tested manually with a few iterations of this configuration: ```hcl terraform { required_providers { aws = "2.70.0" } required_version = "0.12.28" } provider "aws" { region = "us-east-2" } variable "public_root_domain" { description = "Publicly accessible domain for ACM testing" type = string } data "aws_route53_zone" "public_root_domain" { name = var.public_root_domain } resource "aws_acm_certificate" "new" { domain_name = "new.${var.public_root_domain}" subject_alternative_names = [ "new1.${var.public_root_domain}", "new2.${var.public_root_domain}", "new3.${var.public_root_domain}", ] validation_method = "DNS" } resource "aws_route53_record" "new" { for_each = { for dvo in aws_acm_certificate.new.domain_validation_options: dvo.domain_name => { name = dvo.resource_record_name record = dvo.resource_record_value type = dvo.resource_record_type } } allow_overwrite = true name = each.value.name records = [each.value.record] ttl = 60 type = each.value.type zone_id = data.aws_route53_zone.public_root_domain.zone_id } resource "aws_acm_certificate_validation" "new" { certificate_arn = aws_acm_certificate.new.arn validation_record_fqdns = [for record in aws_route53_record.new: record.fqdn] } resource "aws_acm_certificate" "wildcard" { domain_name = var.public_root_domain subject_alternative_names = ["*.${var.public_root_domain}"] validation_method = "DNS" } resource "aws_route53_record" "wildcard" { for_each = { for dvo in aws_acm_certificate.wildcard.domain_validation_options: dvo.domain_name => { name = dvo.resource_record_name record = dvo.resource_record_value type = dvo.resource_record_type } } allow_overwrite = true name = each.value.name records = [each.value.record] ttl = 60 type = each.value.type zone_id = data.aws_route53_zone.public_root_domain.zone_id } resource "aws_acm_certificate_validation" "wildcard" { certificate_arn = aws_acm_certificate.wildcard.arn validation_record_fqdns = [for record in aws_route53_record.wildcard: record.fqdn] } ``` * docs/service/acm: Fix terrafmt reports Previously: ``` website/docs/r/acm_certificate.html.markdown:83 website/docs/r/acm_certificate_validation.html.markdown:25 website/docs/r/acm_certificate_validation.html.markdown:67 ``` Update CHANGELOG for #14199 Implement Disappears test for API Gateway resources (#13243) * add disappears test case for APIGW API Key * add disappears test case for APIGW Authorizer * add disappears test case for APIGW Base Path * add disappears test case for APIGW Client Cert * add disappears test case for APIGW Deployment * add disappears test case for APIGW Doc Part * add disappears test case for APIGW Doc Ver * add disappears test case for APIGW Domain Name * add disappears test case for APIGW Gateway Response * add disappears test case for APIGW Integration Response * add disappears test case for APIGW Integration * add disappears test case for APIGW Method * add disappears test case for APIGW Method Response * add disappears test case for APIGW Method Settings * add disappears test case for APIGW Model * add disappears test case for APIGW Request Validator * add disappears test case for APIGW Resource * add disappears test case for APIGW Rest API * add disappears test case for APIGW Stage * add disappears test case for APIGW Usage Plan Key * add disappears test case for APIGW Usage Plan * add disappears test case for APIGW VPC Link * fix * fix lint docs/resource/aws_codebuild_project: Add SECRETS_MANAGER to the CodeBuild environment_variable type (#14200) Updates alexa example Updates api-gateway-websocket-chat-app example Updates asg example Updates cloudhsm example Updates cloudwatch-events kinesis and sns examples Updates cognito-user-pool example Updates count example Updates dx-gateway-cross-account-vgw-association example Updates ecs-alb example Updates eip example Updates eks-getting-started example Updates elasticsearch-domain example Updates elb example Updates lambda example Updates lambda-file-system example Updates networking example Updates rds example Updates s3-api-gateway-integration example Updates s3-cross-account-access Updates sagemaker example Updates transit-gateway-cross-account-peering-attachment example Updates transit-gateway-cross-account-vpc-attachment example Updates two-tier example Updates workspaces example Updates example action workflow to validate only with Terraform 0.12. Adds error for testing Restore `terraform validate` output Only check for warnings if there are no errors Fixes bash conditional Wraps jq result in quotes to force it into a string to avoid "unary operator expected" error Tightens warning check Updates warning equality Simplify warning check since it will exit on syntax errors Resetting warning test to debug it Add back terraform validate -json Adds back jq Echoes warning count Step-by-step Baby steps One step back Again Try anything Drops checks for warnings Removes error added for testing Got it! resource/aws_ssm_maintenance_window_task: Remove deprecated logging_info and task_parameters configuration blocks (#14311) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/7823 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (13.56s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (14.66s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (22.46s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (22.75s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (36.30s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (36.56s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (39.53s) ``` Update CHANGELOG for #14311 resource/aws_lb_listener_rule: Remove deprecated condition configuration block field and values arguments (#14309) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/8268 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Already documented in the version 3 upgrade guide. Output from acceptance testing: ``` --- PASS: TestAccAWSLBListenerRule_Action_Order (242.39s) --- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (172.01s) --- PASS: TestAccAWSLBListenerRule_BackwardsCompatibility (192.52s) --- PASS: TestAccAWSLBListenerRule_basic (205.77s) --- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (234.49s) --- PASS: TestAccAWSLBListenerRule_cognito (190.75s) --- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (10.86s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader (227.40s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (194.36s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (1.43s) --- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (195.55s) --- PASS: TestAccAWSLBListenerRule_conditionMultiple (269.78s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern (199.17s) --- PASS: TestAccAWSLBListenerRule_conditionQueryString (195.57s) --- PASS: TestAccAWSLBListenerRule_conditionSourceIp (186.73s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (274.24s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (267.11s) --- PASS: TestAccAWSLBListenerRule_fixedResponse (213.36s) --- PASS: TestAccAWSLBListenerRule_forwardWeighted (213.62s) --- PASS: TestAccAWSLBListenerRule_oidc (206.04s) --- PASS: TestAccAWSLBListenerRule_priority (377.75s) --- PASS: TestAccAWSLBListenerRule_redirect (248.43s) --- PASS: TestAccAWSLBListenerRule_updateFixedResponse (189.01s) --- PASS: TestAccAWSLBListenerRule_updateRulePriority (206.44s) ``` Update CHANGELOG for #14309 resource/aws_cognito_user_pool: Remove deprecated admin_create_user_config.unused_account_validity_days argument (#14294) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/10890 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSCognitoUserPool_basic (16.93s) --- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (47.75s) --- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (50.45s) --- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (46.37s) --- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (41.83s) --- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (35.22s) --- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (36.72s) --- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (45.69s) --- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (43.87s) --- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (41.27s) --- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (21.39s) --- PASS: TestAccAWSCognitoUserPool_update (38.77s) --- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (26.14s) --- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (13.70s) --- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (32.33s) --- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (23.59s) --- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (21.89s) --- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (21.15s) --- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (46.71s) --- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (36.75s) --- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (22.83s) --- PASS: TestAccAWSCognitoUserPool_withTags (33.77s) --- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (28.12s) --- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (21.48s) ``` Update CHANGELOG for #14294 tests/provider: Ensure awsproviderlint source is dependency and lint checked (#14131) * tests/provider: Ensure awsproviderlint source is dependency and lint checked Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/14129 * provider: Add awsproviderlint to make fmt target provider: Initial snapshot build workflow (#14140) Using GitHub Actions artifacts, sets up daily snapshot builds of master and allows other snapshot builds. resource/aws_iam_access_key: Remove deprecated ses_smtp_password attribute (#14299) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/11144 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSAccessKey_basic (5.87s) --- PASS: TestAccAWSAccessKey_encrypted (5.97s) --- PASS: TestAccAWSAccessKey_inactive (9.72s) ``` Update CHANGELOG for #14299 provider: Remove deprecated kinesis_analytics and r53 custom endpoint arguments (#14238) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSProvider_Region_AwsCommercial (3.64s) --- PASS: TestAccAWSProvider_Region_AwsChina (3.64s) --- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (3.65s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (4.00s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (4.00s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (4.01s) --- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (4.01s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (4.01s) --- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (4.02s) --- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (4.01s) --- PASS: TestAccAWSProvider_Endpoints (4.08s) --- PASS: TestAccAWSProvider_AssumeRole_Empty (7.80s) ``` Update CHANGELOG for #14238 resource/aws_glue_job: Remove deprecated allocated_capacity argument (#14296) Reference: https://github.com/terraform-providers/terraform-provider-aws/pull/7340 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSGlueJob_basic (14.45s) --- PASS: TestAccAWSGlueJob_Description (21.70s) --- PASS: TestAccAWSGlueJob_GlueVersion (21.74s) --- PASS: TestAccAWSGlueJob_MaxRetries (21.92s) --- PASS: TestAccAWSGlueJob_Command (21.95s) --- PASS: TestAccAWSGlueJob_DefaultArguments (22.08s) --- PASS: TestAccAWSGlueJob_NotificationProperty (22.10s) --- PASS: TestAccAWSGlueJob_Timeout (22.13s) --- PASS: TestAccAWSGlueJob_ExecutionProperty (22.43s) --- PASS: TestAccAWSGlueJob_MaxCapacity (22.43s) --- PASS: TestAccAWSGlueJob_SecurityConfiguration (22.48s) --- PASS: TestAccAWSGlueJob_WorkerType (29.22s) --- PASS: TestAccAWSGlueJob_Tags (29.29s) --- PASS: TestAccAWSGlueJob_PythonShell (30.12s) ``` Update CHANGELOG for #14296 resource/aws_iam_instance_profile: Remove deprecated roles argument (#14303) Reference: https://github.com/hashicorp/terraform/pull/13130 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Output from acceptance testing: ``` --- PASS: TestAccAWSIAMInstanceProfile_withoutRole (6.44s) --- PASS: TestAccAWSIAMInstanceProfile_basic (6.92s) --- PASS: TestAccAWSIAMInstanceProfile_namePrefix (6.94s) --- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (53.25s) --- PASS: TestAccAWSAppautoScalingTarget_emrCluster (790.81s) --- PASS: TestAccAWSBeanstalkEnv_tier (518.46s) --- PASS: TestAccAWSIAMRole_testNameChange (12.80s) --- PASS: TestAccAWSInstance_instanceProfileChange (204.32s) --- PASS: TestAccAWSInstance_withIamInstanceProfile (115.26s) --- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (21.61s) ``` Update CHANGELOG for #14303 Remove hardcoded AMIs and AZs resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsByTopic and return immediately on errors (#14262) * tests/resource/aws_sns_topic_subscription: Fix recurring and unrelated test configuration error Previously: ``` --- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (63.28s) testing.go:684: Step 0 error: After applying this step, the plan was not empty: DIFF: UPDATE: aws_api_gateway_authorizer.test ... authorizer_result_ttl_in_seconds: "300" => "0" ``` Output from acceptance testing: ``` --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s) ``` * resource/aws_sns_topic_subscription: Use paginated ListSubscriptionsByTopic and return immediately on errors Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Output from acceptance testing: ``` --- PASS: TestAccAWSSNSTopicSubscription_basic (13.47s) --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (27.13s) --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (28.12s) --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (28.38s) --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (48.31s) --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (91.18s) ``` Update CHANGELOG for #14262 service/directconnect: vpn_gateway_id Argument Removals and Increase aws_dx_gateway_association Default Timeouts (#14144) * resource/aws_dx_gateway_association: Increase default create/update/delete timeouts to 30 minutes Previously, we were seeing consistent failures across many of acceptance tests: ``` TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount: testing.go:684: Step 1 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-a59d30b3-e6de-435e-bb17-cd7ed23f400evgw-06bccd6488d2b8d87) to become available: timeout while waiting for state to become 'associated' (last state: 'updating', timeout: 10m0s) TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount: testing.go:684: Step 1 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-a8b1b976-c0a1-4b64-8560-9d9cc45d11a3vgw-0a2e52679acf9c250) to become available: timeout while waiting for state to become 'associated' (last state: 'updating', timeout: 10m0s) --- FAIL: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (989.81s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-48d0e3d3-e131-443d-9693-e64eff519baatgw-0a2a0ea77f65ed202) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (991.80s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-9f9c1ed2-97b6-41c5-8018-0724f6162b59tgw-06f7ce56df96282d7) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (1816.92s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-76c9d0f4-b0aa-4b1b-96d9-10ce8c3ca025vgw-0c47a2c63baf7d4d8) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) testing.go:745: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: error waiting for Direct Connect gateway association (ga-76c9d0f4-b0aa-4b1b-96d9-10ce8c3ca025vgw-0c47a2c63baf7d4d8) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (1816.89s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-12a5c1e8-322e-4bc1-8a5a-f4b778a00db3vgw-09c811d121256131b) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) testing.go:745: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: error waiting for Direct Connect gateway association (ga-12a5c1e8-322e-4bc1-8a5a-f4b778a00db3vgw-09c811d121256131b) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (1819.25s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-ccf678f2-5d51-441e-86c5-308c731f26abvgw-063e75f539bc3719c) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) testing.go:745: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: error waiting for Direct Connect gateway association (ga-ccf678f2-5d51-441e-86c5-308c731f26abvgw-063e75f539bc3719c) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (2487.01s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-054e2b0e7ecf45c8d) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) Error: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-057b39dbec7338ec1) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) testing.go:745: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: error waiting for Direct Connect gateway association (ga-5d93ccd0-8344-4ee6-95f8-58af27e01301vgw-057b39dbec7338ec1) to be deleted: timeout while waiting for state to become 'disassociated, deleted' (last state: 'disassociating', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (2529.42s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-ad8143a9-657e-4ed2-9ebb-a78dd2bee2c1vgw-0d552249edec48941) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) testing.go:745: Error destroying resource! WARNING: Dangling resources may exist. The full state and error is shown below. Error: errors during apply: Error waiting for VPN Gateway "vgw-0d552249edec48941" to detach from VPC "vpc-0cbba5ddf6a4ec7ba": timeout while waiting for state to become 'detached' (last state: 'detaching', timeout: 15m0s) --- FAIL: TestAccAwsDxGatewayAssociation_deprecatedSingleAccount (2551.41s) testing.go:684: Step 0 error: errors during apply: Error: error waiting for Direct Connect gateway association (ga-c1c37095-ab8d-4dcd-9f97-b369face1ad4vgw-0576f5ab3096ace51) to become available: timeout while waiting for state to become 'associated' (last state: 'associating', timeout: 15m0s) ``` * service/directconnect: Remove vpn_gateway_id arguments Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13398 Changes: ``` * resource/aws_dx_gateway_association: Remove `vpn_gateway_id` argument * resource/aws_dx_gateway_association_proposal: Remove `vpn_gateway_id` argument ``` Output from acceptance testing: ``` --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewaySingleAccount (2063.56s) --- PASS: TestAccAwsDxGatewayAssociation_basicTransitGatewayCrossAccount (2556.75s) --- PASS: TestAccAwsDxGatewayAssociation_multiVpnGatewaysSingleAccount (2668.06s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewaySingleAccount (2674.09s) --- PASS: TestAccAwsDxGatewayAssociation_basicVpnGatewayCrossAccount (2677.20s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewaySingleAccount (3612.36s) --- PASS: TestAccAwsDxGatewayAssociation_allowedPrefixesVpnGatewayCrossAccount (3856.32s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicVpnGateway (88.64s) --- PASS: TestAccAwsDxGatewayAssociationProposal_disappears (96.50s) --- PASS: TestAccAwsDxGatewayAssociationProposal_AllowedPrefixes (121.18s) --- PASS: TestAccAwsDxGatewayAssociationProposal_basicTransitGateway (182.42s) ``` * tests/resource/aws_dx_gateway_association: Ensure v0 state upgrade is still covered by acceptance testing Output from acceptance testing: ``` --- PASS: TestAccAwsDxGatewayAssociation_V0StateUpgrade (2605.48s) ``` Update CHANGELOG for #14144 docs/resource/aws_security_group: Update `cidr_blocks` value to list (#14329) add support for zero ttl add validation for `authorizer_uri`, `authorizer_credentials` changes for %w remove deprecated func use set len func revert validation for `authorizer_uri` refactor tests refactor tests Update CHANGELOG for #12643 resource/aws_appautoscaling_target: Remove DeregisterScalableTarget retries on all errors and add disappears test (#14259) Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13826 Output from acceptance testing: ``` --- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (20.68s) --- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (25.17s) --- PASS: TestAccAWSAppautoScalingTarget_basic (43.13s) --- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (57.42s) --- PASS: TestAccAWSAppautoScalingTarget_disappears (71.79s) --- PASS: TestAccAWSAppautoScalingTarget_emrCluster (840.33s) --- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameName (24.97s) --- PASS: TestAccAWSAppautoScalingPolicy_dynamodb_table (26.58s) --- PASS: TestAccAWSAppautoScalingPolicy_multiplePoliciesSameResource (28.13s) --- PASS: TestAccAWSAppautoScalingPolicy_dynamodb_index (37.07s) --- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (71.64s) --- PASS: TestAccAWSAppautoScalingPolicy_disappears (75.45s) --- PASS: TestAccAWSAppautoScalingPolicy_basic (77.30s) --- PASS: TestAccAWSAppautoScalingPolicy_scaleOutAndIn (79.17s) --- PASS: TestAccAWSAppautoScalingPolicy_ResourceId_ForceNew (83.72s) ``` Update CHANGELOG for #14259 update statefuncs to use global method update statefuncs to use global method Update provider's S3 bucket lookup to use GetBucketRegion utility (#14221) * Update provider's S3 bucket lookup to use GetBucketRegion utility Replaces the usage of S3's GetBucketLocation with the aws-sdk-go's GetBucketRegion utility. This utility can discover the bucket's region without authentication, and can be configured to be compatible with FIPS endpoints. Fixes https://github.com/terraform-providers/terraform-provider-aws/issues/14217 Related to https://github.com/aws/aws-sdk-go/issues/3115 * Add AWS SDK for Go s3manager dependency Adds a dependency on the AWS SDK for Go's `s3manager`, and `s3iface` packages. These packages make the s3manager packages's GetBucketRegion utility available for discovering a S3 bucket's locations. These packages are used by PR #14221. Update CHANGELOG for #14221 and other minor formatting fixes refactor trimTrailingPeriod method

anGie44 · 2020-07-27T22:23:49Z

Ready for re-review :)

Output of acceptance tests:

--- PASS: TestSuppressEquivalentTypeStringBoolean (0.00s)
--- PASS: TestSuppressEquivalentJsonDiffsWhitespaceAndNoWhitespace (0.00s)
--- PASS: TestSuppressCloudFormationTemplateBodyDiffs (0.00s)
--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (7.66s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (108.98s)
--- PASS: TestAccAWSAcmCertificate_san_single (120.36s)
--- PASS: TestAccAWSAcmCertificate_wildcard (121.21s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (133.47s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (149.46s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (150.02s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (177.62s)
--- PASS: TestAccAWSAcmCertificate_root (177.66s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (177.67s)
--- PASS: TestAccAWSAcmCertificate_privateCert (178.54s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (178.78s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (191.74s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (193.02s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (204.93s)
--- PASS: TestAccAWSAcmCertificate_tags (215.43s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (15.02s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (17.08s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (128.92s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (197.69s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (200.71s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (424.06s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (424.97s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (144.67s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (238.96s)
--- PASS: TestCleanRecordName (0.00s)
--- PASS: TestExpandRecordName (0.00s)
--- PASS: TestNormalizeAwsAliasName (0.00s)
--- PASS: TestParseRecordId (0.00s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (13.10s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (14.54s)
--- PASS: TestAccAWSAcmCertificate_privateCert (18.49s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (19.38s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (28.46s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (35.18s)
--- PASS: TestAccDataSourceAwsRoute53Zone_name (55.68s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (59.90s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (109.69s)
--- PASS: TestAccAWSRoute53Record_disappears (130.63s)
--- PASS: TestAccAWSRoute53Record_basic (132.54s)
--- PASS: TestAccAWSRoute53Record_spfSupport (138.40s)
--- PASS: TestAccAWSRoute53Record_txtSupport (147.18s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (147.45s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (149.80s)
--- PASS: TestAccAWSRoute53Record_underscored (148.96s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (159.49s)
--- PASS: TestAccAWSRoute53Record_caaSupport (147.99s)
--- PASS: TestAccAWSRoute53Record_generatesSuffix (149.07s)
--- PASS: TestAccAWSRoute53Record_failover (148.38s)
--- PASS: TestAccAWSRoute53Record_weighted_basic (148.55s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (140.70s)
--- PASS: TestAccAWSRoute53Record_Alias_Elb (150.63s)
--- PASS: TestAccAWSRoute53Record_wildcard (191.90s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (214.14s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (221.04s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (221.58s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (194.91s)
--- PASS: TestAccAwsRoute53ResolverRule_basic (29.60s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (42.24s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (45.92s)
--- PASS: TestAccAWSRoute53Record_geolocation_basic (133.36s)
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (142.51s)
--- PASS: TestAccAWSRoute53Record_latency_basic (142.68s)
--- PASS: TestAccAWSRoute53Record_empty (148.49s)
--- PASS: TestCleanZoneID (0.00s)
--- PASS: TestCleanChangeID (0.00s)
--- PASS: TestTrimTrailingPeriod (0.00s)
--- PASS: TestAccAWSRoute53Record_longTXTrecord (139.76s)
--- PASS: TestAccAWSRoute53Record_TypeChange (190.80s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_TypeChange (192.42s)
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (146.55s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (188.02s)
--- PASS: TestAccAWSRoute53Zone_disappears (46.25s)
--- PASS: TestAccAWSRoute53Zone_basic (47.94s)
--- PASS: TestAccAWSRoute53Record_AliasChange (200.65s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_SetIdentifierChange (221.51s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (177.97s)
--- PASS: TestAccAWSRoute53Record_NameChange (232.35s)
--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (181.43s)
--- PASS: TestAccAWSRoute53Zone_multiple (53.11s)
--- PASS: TestAccAWSSESDomainIdentity_disappears (6.69s)
--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (9.45s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (54.07s)
--- PASS: TestAccAWSRoute53Zone_Comment (59.97s)
--- PASS: TestAccAWSSESDomainIdentity_basic (10.56s)
--- PASS: TestAccAwsSesDomainIdentityVerification_nonexistent (3.84s)
--- PASS: TestAccAwsSesDomainIdentityVerification_timeout (9.74s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (152.22s)
--- PASS: TestAccAWSRoute53Zone_Tags (65.16s)
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (167.38s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (296.35s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (162.56s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (175.40s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (85.78s)
--- PASS: TestAccAWSRoute53ZoneAssociation_region (161.13s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (276.48s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (145.82s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (218.16s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (205.26s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (502.90s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (243.11s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (437.44s)

--- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (1.44s) -- also failing in master related to explicit provider config
--- SKIP: TestAccAWSAcmCertificateDataSource_singleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_multipleIssued (0.00s)
--- SKIP: TestAccAwsSesDomainIdentityVerification_basic (0.00s)

bflad

Hey @anGie44 👋 Just a few more things and this should be good to go. Thanks!

bflad · 2020-07-29T12:32:28Z

-					// trailing period, which generates an ACM API error
-					return strings.TrimSuffix(v.(string), ".")
-				},
+				StateFunc:     trimTrailingPeriod,


If the ACM API does not accept trailing periods, which if I remember correctly does not, I think our goal during this major release should be fixing up the resource to match the API expectations and return a validation error. Since we are fixing the source of the generally unexpected trailing periods by removing them from the Route 53 data sources/resources, my recommendation would be to remove the special handling like this and the custom resource logic from downstream attribute handling. I'm worried about future upkeep and harder code generation. 👍 We can add a ValidateFunc to catch trailing periods to help catch these sooner.

anGie44 · 2020-07-29T21:03:34Z

(Almost)Ready-- for re-review. Just held up on test results for TestAccAWSAcmCertificateDataSource_singleIssued and TestAccAWSAcmCertificateDataSource_multipleIssued

Output of acceptance tests with current branch state:

--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (4.48s)
--- PASS: TestAccAWSSESDomainIdentity_disappears (14.36s)
--- PASS: TestAccAWSSESDomainIdentity_basic (15.81s)

--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (2.03s)
--- PASS: TestAccAWSAcmCertificate_wildcard (58.62s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (58.71s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (63.54s)
--- PASS: TestAccAWSAcmCertificate_root (64.18s)
--- PASS: TestAccAWSAcmCertificate_privateCert (64.62s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (65.75s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (67.03s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (93.52s)
--- PASS: TestAccAWSAcmCertificate_tags (147.12s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (24.12s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (21.79s)
--- PASS: TestAccAWSAcmCertificate_san_single (24.20s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (25.24s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.67s)

--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (16.79s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (21.45s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (213.07s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (275.08s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (349.75s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (351.08s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (352.75s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (380.46s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (385.38s)

--- PASS: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (10.98s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (18.51s)

--- PASS: TestSuppressEquivalentJsonDiffsWhitespaceAndNoWhitespace (0.00s)
--- PASS: TestSuppressCloudFormationTemplateBodyDiffs (0.00s)
--- PASS: TestSuppressEquivalentTypeStringBoolean (0.00s)
--- PASS: TestCleanRecordName (0.00s)
--- PASS: TestExpandRecordName (0.00s)
--- PASS: TestNormalizeAwsAliasName (0.00s)
--- PASS: TestParseRecordId (0.00s)

--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (227.21s)
--- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (3.42s) -- failing in master as well
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (36.18s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (212.02s)

--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (13.13s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (201.69s)

--- PASS: TestAccDataSourceAwsRoute53Zone_name (52.90s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (56.21s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (108.44s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (115.00s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (175.52s)

--- PASS: TestAccAWSRoute53Record_spfSupport (124.03s)
--- PASS: TestAccAWSRoute53Record_basic (126.80s)
--- PASS: TestAccAWSRoute53Record_underscored (126.94s)
--- PASS: TestAccAWSRoute53Record_txtSupport (148.98s)
--- PASS: TestAccAWSRoute53Record_caaSupport (140.52s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (152.92s)
--- PASS: TestAccAWSRoute53Record_generatesSuffix (143.67s)
--- PASS: TestAccAWSRoute53Record_disappears (165.82s)
--- PASS: TestAccAWSRoute53Record_failover (157.65s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (208.53s)
--- PASS: TestAccAWSRoute53Record_Alias_Elb (160.39s)
--- PASS: TestAccAWSRoute53Record_weighted_basic (186.06s)
--- PASS: TestAccAWSRoute53Record_wildcard (205.17s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (171.37s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (212.98s)
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (167.34s)
--- PASS: TestAccAWSRoute53Record_geolocation_basic (157.47s)
--- PASS: TestAccAWSRoute53Record_latency_basic (173.48s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_SetIdentifierChange (201.78s)
--- PASS: TestAccAWSRoute53Record_empty (157.02s)
--- PASS: TestAccAWSRoute53Record_longTXTrecord (149.95s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_TypeChange (200.09s)
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (143.59s)
--- PASS: TestAccAWSRoute53Record_AliasChange (201.22s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (211.69s)
--- PASS: TestAccAWSRoute53Record_TypeChange (225.01s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (190.06s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (292.63s)
--- PASS: TestAccAWSRoute53Record_NameChange (267.46s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (489.62s)

--- PASS: TestAccAwsRoute53ResolverRule_basic (29.93s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (42.48s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (46.58s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (253.83s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (426.16s)

--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (141.60s)

--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (174.30s)
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (186.10s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (171.13s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (197.16s)
--- PASS: TestAccAWSRoute53ZoneAssociation_region (182.72s)

--- PASS: TestCleanZoneID (0.00s)
--- PASS: TestCleanChangeID (0.00s)
--- PASS: TestTrimTrailingPeriod (0.00s)

--- PASS: TestAccAWSRoute53Zone_disappears (46.60s)
--- PASS: TestAccAWSRoute53Zone_basic (59.60s)
--- PASS: TestAccAWSRoute53Zone_multiple (55.23s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (52.90s)
--- PASS: TestAccAWSRoute53Zone_Comment (59.71s)
--- PASS: TestAccAWSRoute53Zone_Tags (69.87s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (85.39s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (344.10s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (153.35s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (229.52s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (237.52s)

--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (1.02s)
--- PASS: TestAccAWSSESDomainIdentity_basic (7.02s)
--- PASS: TestAccAWSSESDomainIdentity_disappears (6.10s)

--- PASS: TestAccAwsSesDomainIdentityVerification_nonexistent (3.56s)
--- PASS: TestAccAwsSesDomainIdentityVerification_timeout (9.80s)

bflad

Looks good to me, let's get this in. 🚀

anGie44 · 2020-07-30T03:31:09Z

Missed an unintended side-effect after last commit 😓 Another round of test runs returned failures in acm_certificate_validation as configs that use the aws_route53_record reference the acm_certificate domain_validation_options.resource_record_name argument as input to name, resulting in plan-time validation errors. 3349867 addresses this as well as removes extraneous cleanup of subjectAlternativeNames as they are validated at plan-time for the trailing period and are not returned by the API with trailing periods

Output of acceptance tests:

Previously Failing:

--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (19.89s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (141.82s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (142.77s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (143.07s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (173.55s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (223.74s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (224.76s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (22.92s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (201.40s)

Re-confirmed

--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (227.21s)
--- FAIL: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (2.86s) -- known failure in Alternate
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (19.65s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (28.93s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (13.50s)
--- PASS: TestAccAWSAcmCertificate_privateCert (19.56s)
--- PASS: TestAccAWSRoute53Record_AliasChange (176.44s)
--- PASS: TestAccAWSRoute53Record_Alias_Elb (143.66s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (152.97s)
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (120.21s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (519.64s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_SetIdentifierChange (181.08s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_TypeChange (192.02s)
--- PASS: TestAccAWSRoute53Record_NameChange (233.22s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (176.41s)
--- PASS: TestAccAWSRoute53Record_TypeChange (186.60s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (183.83s)
--- PASS: TestAccAWSRoute53Record_basic (250.34s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (153.08s)
--- PASS: TestAccAWSRoute53Record_basic_name_trailingPeriod (3.82s)
--- PASS: TestAccAWSRoute53Record_caaSupport (142.84s)
--- PASS: TestAccAWSRoute53Record_disappears (135.24s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (185.05s)
--- PASS: TestAccAWSRoute53Record_empty (116.13s)
--- PASS: TestAccAWSRoute53Record_failover (165.19s)
--- PASS: TestAccAWSRoute53Record_generatesSuffix (151.73s)
--- PASS: TestAccAWSRoute53Record_geolocation_basic (155.50s)
--- PASS: TestAccAWSRoute53Record_latency_basic (149.83s)
--- PASS: TestAccAWSRoute53Record_longTXTrecord (123.63s)
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (129.51s)
--- PASS: TestAccAWSRoute53Record_spfSupport (139.49s)
--- PASS: TestAccAWSRoute53Record_txtSupport (144.56s)
--- PASS: TestAccAWSRoute53Record_underscored (153.56s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (265.66s)
--- PASS: TestAccAWSRoute53Record_weighted_basic (137.93s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (191.75s)
--- PASS: TestAccAWSRoute53Record_wildcard (188.57s)
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (135.17s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (131.70s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (142.62s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (139.52s)
--- PASS: TestAccAWSRoute53ZoneAssociation_region (140.09s)
--- PASS: TestAccAWSRoute53Zone_Comment (54.67s)
--- PASS: TestAccAWSRoute53Zone_DelegationSetID (62.55s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy (199.64s)
--- PASS: TestAccAWSRoute53Zone_ForceDestroy_TrailingPeriod (200.53s)
--- PASS: TestAccAWSRoute53Zone_Tags (72.33s)
--- PASS: TestAccAWSRoute53Zone_VPC_Multiple (163.80s)
--- PASS: TestAccAWSRoute53Zone_VPC_Single (85.89s)
--- PASS: TestAccAWSRoute53Zone_VPC_Updates (251.89s)
--- PASS: TestAccAWSRoute53Zone_basic (50.36s)
--- PASS: TestAccAWSRoute53Zone_disappears (41.61s)
--- PASS: TestAccAWSRoute53Zone_multiple (48.79s)
--- PASS: TestAccAWSSESDomainIdentity_basic (6.69s)
--- PASS: TestAccAWSSESDomainIdentity_disappears (6.40s)
--- PASS: TestAccAWSSESDomainIdentity_trailingPeriod (1.01s)
--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (171.64s)
--- PASS: TestAccAwsRoute53ResolverRule_basic (50.08s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (344.71s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (416.60s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (43.30s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (66.60s)
--- PASS: TestAccAwsSesDomainIdentityVerification_nonexistent (3.70s)
--- PASS: TestAccAwsSesDomainIdentityVerification_timeout (9.72s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (241.68s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (35.67s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (231.77s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (14.01s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (55.10s)
--- PASS: TestAccDataSourceAwsRoute53Zone_name (55.32s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (108.43s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (126.86s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (114.10s)
--- PASS: TestCleanChangeID (0.00s)
--- PASS: TestCleanRecordName (0.00s)
--- PASS: TestCleanZoneID (0.00s)
--- PASS: TestExpandRecordName (0.00s)
--- PASS: TestNormalizeAwsAliasName (0.00s)
--- PASS: TestParseRecordId (0.00s)
--- PASS: TestSuppressCloudFormationTemplateBodyDiffs (0.00s)
--- PASS: TestSuppressEquivalentJsonDiffsWhitespaceAndNoWhitespace (0.00s)
--- PASS: TestSuppressEquivalentTypeStringBoolean (0.00s)
--- PASS: TestTrimTrailingPeriod (0.00s)

--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (2.17s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (27.62s)
--- PASS: TestAccAWSAcmCertificate_wildcard (31.74s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (48.15s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (49.78s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (52.99s)
--- PASS: TestAccAWSAcmCertificate_privateCert (53.13s)
--- PASS: TestAccAWSAcmCertificate_san_single (90.29s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (58.88s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (65.68s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (70.28s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (108.38s)
--- PASS: TestAccAWSAcmCertificate_tags (127.21s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (1.71s)
--- PASS: TestAccAWSAcmCertificate_root (21.90s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (22.30s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (24.41s)

--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (28.76s)

bflad · 2020-07-30T14:59:44Z

 				Required: true,
 				ForceNew: true,
 				StateFunc: func(v interface{}) string {
-					value := strings.TrimSuffix(v.(string), ".")


If there are valid other places that can give this resource a trailing period, I guess we may want to walk back on adjusting this particular attribute and allow it to still handle both with and without the trailing period. I'd rather avoid changing the ACM validation record behavior since that could affect interactions with DNS systems outside of AWS.

gotcha -- does seem risky in cases where that ACM attribute I changed might be used in ways not covered by our tests; i'll revert and move back this state func /remove the validation here 👍

Thank you for updating the comment there, super helpful 👍

… cert computed attr val

bflad · 2020-07-30T16:19:52Z

 			}
 		}
 	}
-	recName = strings.TrimSuffix(recName, ".")


I think we can keep this here now as well (and the previous unit test case) 👍

yess just discovered this one! interesting enough, i think our tests don't seem to cover a case where it would fail without this line back in b/c in TC the tests all just passed ... aside from the unit tests

We would need to implement an acceptance test with a custom ImportStateIDFunc since the ImportState testing pulls in the ID with the trimmed value. Maybe good to have, but doesn't need to happen right now. 😄

Hmm I think the TestAccAWSRoute53Record_basic_trailingPeriodAndZoneID I most recently added should hopefully account for catching the importstateverify error ... atleast it fails when the above code is omitted :)

bflad

Just the one last thing to allow trailing period imports still, otherwise looks good and thank you for sticking through this challenging one. 🙇

anGie44 · 2020-07-30T17:23:09Z

OK ready to go! Re-confirmed tests in TC and separately ran ACM tests:

Output:

--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (1.42s)
--- PASS: TestAccAWSAcmCertificate_privateCert (161.93s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (206.57s)
--- PASS: TestAccAWSAcmCertificate_wildcard (222.99s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (223.23s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (223.74s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (223.76s)
--- PASS: TestAccAWSAcmCertificate_san_single (234.98s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (234.99s)
--- PASS: TestAccAWSAcmCertificate_root (235.01s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (235.25s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (235.33s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (236.16s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (265.83s)
--- PASS: TestAccAWSAcmCertificate_tags (277.30s)

--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsEmail (35.66s)
--- PASS: TestAccAWSAcmCertificateValidation_timeout (36.14s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRoot (177.20s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsRootAndWildcard (177.95s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcardAndRoot (186.68s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsWildcard (189.72s)
--- PASS: TestAccAWSAcmCertificateValidation_basic (225.49s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdnsSan (226.39s)
--- PASS: TestAccAWSAcmCertificateValidation_validationRecordFqdns (238.18s)

ghost · 2020-07-31T02:17:00Z

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-08-30T17:13:51Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jul 16, 2020

anGie44 added this to the v3.0.0 milestone Jul 16, 2020

anGie44 marked this pull request as ready for review July 17, 2020 15:41

anGie44 requested a review from a team July 17, 2020 15:41

anGie44 changed the title ~~service/route53: remove trailing period from domainname/name attributes~~ service/route53: remove trailing period from domainname/name attributes in resolver_rule and zone resources Jul 17, 2020

anGie44 marked this pull request as draft July 21, 2020 04:57

ghost added documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 21, 2020

anGie44 marked this pull request as ready for review July 21, 2020 08:17

anGie44 force-pushed the b-route53-zone-domain branch from 82c2362 to 44e6869 Compare July 21, 2020 09:30

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

anGie44 marked this pull request as draft July 21, 2020 19:35

ghost added service/acm Issues and PRs that pertain to the acm service. service/ses Issues and PRs that pertain to the ses service. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 22, 2020

anGie44 force-pushed the b-route53-zone-domain branch from cfb923a to 4646ede Compare July 22, 2020 16:52

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 22, 2020

anGie44 force-pushed the b-route53-zone-domain branch from 4646ede to 44e6869 Compare July 22, 2020 16:52

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 22, 2020

anGie44 force-pushed the b-route53-zone-domain branch from 20ce3d6 to dfbc285 Compare July 22, 2020 17:20

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 22, 2020

ghost added size/XL Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 22, 2020

anGie44 force-pushed the b-route53-zone-domain branch from 275abb5 to 33aa0ec Compare July 22, 2020 18:32

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 22, 2020

anGie44 marked this pull request as ready for review July 22, 2020 18:44

bflad suggested changes Jul 23, 2020

View reviewed changes

Comment thread website/docs/guides/version-3-upgrade.html.md Outdated

Comment thread website/docs/guides/version-3-upgrade.html.md Outdated

Comment thread aws/diff_suppress_funcs.go

Comment thread aws/resource_aws_route53_zone.go

Comment thread aws/resource_aws_route53_zone.go Outdated

bflad self-assigned this Jul 23, 2020

anGie44 mentioned this pull request Jul 23, 2020

Resource aws_vpc_dhcp_options should trim trailing . from domain_name #7800

Closed

bflad reviewed Jul 24, 2020

View reviewed changes

Comment thread aws/resource_aws_route53_zone_test.go Outdated

bflad suggested changes Jul 27, 2020

View reviewed changes

bflad and others added 2 commits July 27, 2020 15:57

fixup acctests with trailing period and documentation

03dd714

revert domain name trim at Create time and update docs

3ae10dd

bflad suggested changes Jul 29, 2020

View reviewed changes

bflad approved these changes Jul 29, 2020

View reviewed changes

CR updates to remove custom period handling and add validation instead

dc19585

bflad reviewed Jul 30, 2020

View reviewed changes

update route53 record to allow trailing period in name and revert acm…

9eb3147

… cert computed attr val

bflad reviewed Jul 30, 2020

View reviewed changes

bflad approved these changes Jul 30, 2020

View reviewed changes

bring back trimming of name at import time

45cc659

Conversation

anGie44 commented Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Uh oh!

anGie44 commented Jul 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

anGie44 commented Jul 27, 2020

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bflad Jul 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anGie44 commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

anGie44 commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bflad Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

anGie44 Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

bflad Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

bflad Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

anGie44 Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bflad Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

anGie44 Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

bflad left a comment

Choose a reason for hiding this comment

Uh oh!

anGie44 commented Jul 30, 2020

Uh oh!

ghost commented Jul 31, 2020

Uh oh!

ghost commented Aug 30, 2020

Uh oh!

Reviewers

Assignees

Labels

anGie44 commented Jul 16, 2020 •

edited

Loading

anGie44 commented Jul 22, 2020 •

edited

Loading

anGie44 commented Jul 29, 2020 •

edited

Loading

anGie44 commented Jul 30, 2020 •

edited

Loading

anGie44 Jul 30, 2020 •

edited

Loading