Skip to content

resource/route53_resolver_rule and data-source/route53_resolver_rule: remove domain_name trailing period#14298

Merged
anGie44 merged 5 commits into
b-route53-zone-domainfrom
b-route53-resolver-rule
Jul 27, 2020
Merged

resource/route53_resolver_rule and data-source/route53_resolver_rule: remove domain_name trailing period#14298
anGie44 merged 5 commits into
b-route53-zone-domainfrom
b-route53-resolver-rule

Conversation

@anGie44

@anGie44 anGie44 commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13510

Release note for CHANGELOG:

resource/route53_resolver_rule: remove custom StateFunc for handling domain_name trailing period
data-source/route53_resolver_rule: remove domain_name trailing period

Output from acceptance testing:


@anGie44 anGie44 requested a review from a team July 22, 2020 18:21
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 22, 2020
@anGie44 anGie44 changed the title resource/route53_resolver_rule: remove custom StateFunc for handling domain_name trailing period resource/route53_resolver_rule and data-source/route53_resolver_rule: remove domain_name trailing period Jul 22, 2020
@anGie44 anGie44 force-pushed the b-route53-resolver-rule branch from fa349a8 to 52280cf Compare July 22, 2020 18:56
@anGie44 anGie44 force-pushed the b-route53-zone-domain branch from 79b9554 to 6b99c3c Compare July 24, 2020 00:01
@anGie44 anGie44 merged commit 4d587c8 into b-route53-zone-domain Jul 27, 2020
@anGie44 anGie44 deleted the b-route53-resolver-rule branch July 27, 2020 18:38
@ghost

ghost commented Aug 27, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant