Technical Debt Theme: Resolve Acceptance Test Failures (EC2)

[breathingdust]

Description

This is a meta-issue which tracks the list of EC2 Acceptance Tests which now consistently fail. The August-October 2020 Roadmap for the AWS Provider includes a technical debt theme which decides an area of debt upon which we want to apply focus.

The focus for this period is improving our Acceptance Test suite. This covers resolving failing and flaky tests. Our initial focus will be to resolve failing tests which exist within our Core Service list.

EC2 Tests Currently Failing

• TestAccAWSSpotFleetRequest_tags
• TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate
• TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination
• TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination
• TestAccAWSInstance_EbsRootDevice_ModifyAll
• TestAccAWSInstance_metadataOptions
• TestAccAWSSpotFleetRequest_withoutSpotPrice
• TestAccAWSFlowLog_LogFormat
• TestAccAWSEIPAssociation_ec2Classic
• TestAccAwsEc2ClientVpn_serial (related to Max # of certs)
• TestAccAWSEIP_Ec2Classic
• TestAccAWSRouteTable_panicEmptyRoute
• TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount
• TestAccAWSInstance_instanceProfileChange
• TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
• TestAccAWSEIPAssociation_spotInstance (passing since 8/19 in Commercial and Gov)
• TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (passing in Commercial and Gov)
• TestAccAWSRoute_changeRouteTable (passing in Commercial and Gov)
• TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (consistently passing since 8/18 in Commercial and Gov)