Skip to content

r/ecr_repository_policy - Read after update + validate policy + disappears test#14193

Merged
gdavison merged 7 commits into
hashicorp:mainfrom
DrFaust92:r/ecr_repo_policy
Mar 25, 2021
Merged

r/ecr_repository_policy - Read after update + validate policy + disappears test#14193
gdavison merged 7 commits into
hashicorp:mainfrom
DrFaust92:r/ecr_repo_policy

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented Jul 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826
Closes #3924
Closes #545

Release note for CHANGELOG:

resource_ecr_repository_policy: add plan time validation for `policy`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrRepositoryPolicy_'
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (63.26s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (54.24s)
--- PASS: TestAccAWSEcrRepositoryPolicy_disappears (33.63s)
--- PASS: TestAccAWSEcrRepositoryPolicy_disappears_repository (28.06s)

@DrFaust92 DrFaust92 requested a review from a team July 15, 2020 19:45
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 15, 2020
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Aug 27, 2020
@DrFaust92 DrFaust92 changed the title r/ecr_repository_policy - add plan time validation to policy + disappears test r/ecr_repository_policy - Read after update + add plan time validation to policy + disappears test Aug 28, 2020
@DrFaust92 DrFaust92 changed the title r/ecr_repository_policy - Read after update + add plan time validation to policy + disappears test r/ecr_repository_policy - Read after update + validate policy + disappears test Aug 28, 2020
chlunde
chlunde reviewed Sep 8, 2020
View reviewed changes
Comment thread aws/resource_aws_ecr_repository_policy.go Outdated
chlunde
chlunde reviewed Sep 8, 2020
View reviewed changes
Comment thread aws/resource_aws_ecr_repository_policy.go Outdated
chlunde
chlunde reviewed Sep 8, 2020
View reviewed changes
Comment thread aws/resource_aws_ecr_repository_policy.go Outdated
@DrFaust92 DrFaust92 requested a review from a team as a code owner December 17, 2020 23:14
@DrFaust92

DrFaust92 commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

rebased

--- PASS: TestAccAWSEcrRepositoryPolicy_disappears_repository (33.65s)
--- PASS: TestAccAWSEcrRepositoryPolicy_disappears (40.01s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (52.15s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (76.40s)

Base automatically changed from master to main January 23, 2021 00:58
DrFaust92 and others added 7 commits March 11, 2021 01:35
@DrFaust92
add plan time validation to policy
9aba1fb 
use enums

read after update
add disappears tests + make tests more specific
@DrFaust92
tf 12 syntax
4698573
@DrFaust92 @chlunde
Update aws/resource_aws_ecr_repository_policy.go
b7a6975 
Co-authored-by: Carl Henrik Lunde <chlunde@gmail.com>
@DrFaust92 @chlunde
Update aws/resource_aws_ecr_repository_policy.go
746298e 
Co-authored-by: Carl Henrik Lunde <chlunde@gmail.com>
@DrFaust92 @chlunde
Update aws/resource_aws_ecr_repository_policy.go
7d0c8cf 
Co-authored-by: Carl Henrik Lunde <chlunde@gmail.com>
@DrFaust92
remove update func
7b7a02d
@DrFaust92
changelog
5ad49fc
@gdavison gdavison self-assigned this Mar 25, 2021
gdavison
gdavison approved these changes Mar 25, 2021
View reviewed changes

@gdavison gdavison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSEcrRepositoryPolicy_disappears_repository (12.88s)
--- PASS: TestAccAWSEcrRepositoryPolicy_disappears (14.31s)
--- PASS: TestAccAWSEcrRepositoryPolicy_basic (25.93s)
--- PASS: TestAccAWSEcrRepositoryPolicy_iam (33.38s)

Comment thread aws/resource_aws_ecr_repository_policy.go
Comment on lines -52 to +53
log.Printf("[DEBUG] Creating ECR resository policy: %s", input)
log.Printf("[DEBUG] Creating ECR repository policy: %#v", input)

@gdavison gdavison Mar 25, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format verb %s is better to use in this case, since AWS SDK structures define String() functions

@gdavison gdavison merged commit 70900dd into hashicorp:main Mar 25, 2021
@github-actions github-actions Bot added this to the v3.34.0 milestone Mar 25, 2021
@ghost

ghost commented Mar 26, 2021

Copy link
Copy Markdown

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/ecr_repo_policy branch April 15, 2021 10:43
@ghost

ghost commented Apr 25, 2021

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gdavison gdavison gdavison approved these changes

+1 more reviewer

@chlunde chlunde chlunde left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gdavison gdavison

Labels

bug Addresses a defect in current functionality. service/ecr Issues and PRs that pertain to the ecr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.34.0

Development

Successfully merging this pull request may close these issues.

aws_ecr_repository_policy swallows InvalidParameterException AWS ECR Policy - need to run terraform apply twice

3 participants

@DrFaust92 @chlunde @gdavison
⚡