r/aws_route53_resolver_query_log_config_association: New resource

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #14877
Additive to #14897.

Release note for CHANGELOG:

New resource `aws_route53_resolver_query_log_config_association`.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:48: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (41.47s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (44.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	44.994s

[DrFaust92]

LGTM 🤖

small question, is it possible to add a disappears test for the parent resource to association resource test ? i from experience thats its sometimes possible.

--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (88.43s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (77.02s)

[ewbankkit]

An aws_route53_resolver_query_log_config can't be deleted if it has active aws_route53_resolver_query_log_config_associations which is why the Route53ResolverQueryLogConfig sweeper depends on the Route53ResolverQueryLogConfigAssociation sweeper running first.

[breathingdust]

LGTM 🚀 Thanks @ewbankkit !

Verified Acceptance Tests (Commercial)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:100: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (33.32s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (38.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.027s

Verified Acceptance Tests (GovCloud)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverQueryLogConfigAssociation_ -timeout 120m
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic
=== CONT  TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears
    resource_aws_route53_resolver_query_log_config_association_test.go:100: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_disappears (31.96s)
--- PASS: TestAccAWSRoute53ResolverQueryLogConfigAssociation_basic (33.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.275s

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!