Modernize aws_sns_topic_subscription

[nikhil-goenka]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12286, closes #17303, closes #17307

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[nikhil-goenka]

@bflad : Just an approach for email support on SNS, what are your thoughts ?

[dmccaffery]

Should this paragraph also be removed as part of this PR?

[okgolove]

Any chances this one will be merged?

[YakDriver]

@nikhil-goenka Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

[nikhil-goenka]

@nikhil-goenka Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

Thank you and will be great to see this branch getting merged, the box has been ticked.

[YakDriver]

The biggest problem with email support is that unconfirmed subscriptions cannot be deleted / unsubscribed. My workaround is to remove the aws_sns_topic_subscription from the state, log a warning, and provide plenty of documentation for this issue. I'd love to get feedback on this approach.

NOTE: It's not a big issue for testing purposes since once the test topic is removed, SNS kills the associated subscriptions.

[YakDriver]

Looks great! Thanks for your work @nikhil-goenka and @chammock! 🎉

Acceptance tests in GovCloud:

--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.28s)
--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.28s)
--- PASS: TestAccAWSSNSTopicSubscription_email (18.14s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (21.83s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (47.23s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (48.52s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (48.52s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (52.97s)
--- SKIP: TestAccAWSSNSTopicSubscription_firehose (53.93s)

On us-west-2:

--- PASS: TestAccAWSSNSTopicSubscription_email (14.93s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (18.18s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (37.10s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (37.97s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (38.05s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (40.86s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (41.26s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (81.65s)
--- PASS: TestAccAWSSNSTopicSubscription_firehose (100.05s)

[ghost]

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!