[WIP] r/aws_transfer_server: Support for VPC subnets/IP addresses

[gazoakley]

Based on the work in #12599. This rebases on top of master, addresses some review comments and removes the calls to modify security groups (this can potentially be addressed in a separate resource).

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bflad]

Hi @gazoakley 👋 Thank you for submitting this and performing the updates. Please note that we are going to wait for the original contributor to potentially reply back in #12599 for two weeks before reviewing this. One thing to note (not sure if its worth doing ahead of a potential reply) is that the aws_transfer_user resource changes were covered via a separate earlier contribution and can be removed from this one, which would speed up the process should we not hear back. 👍

[sshearn]

This can be closed. I made the changes in #12599

[bflad]

#12599 has been merged, which supersedes this pull request. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!