Skip to content

d/rds_orderable_db_instance: Add documentation for argument#15205

Merged
YakDriver merged 1 commit into
masterfrom
f-d-rds-orderable-instance
Sep 23, 2020
Merged

d/rds_orderable_db_instance: Add documentation for argument#15205
YakDriver merged 1 commit into
masterfrom
f-d-rds-orderable-instance

Conversation

@YakDriver

@YakDriver YakDriver commented Sep 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15203

This PR has been gutted in favor of a new data source (#15228). A few useful items remain:

  1. Add documentation for preferred_engine_versions which was not included before (undocumented feature)
  2. Alphabetize arguments (code and docs).
  3. Rename precheck functions for convention conformity

Release note for CHANGELOG:

NONE

The output from acceptance testing on GovCloud:

--- SKIP: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (0.00s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (21.69s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (27.25s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (39.72s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (42.38s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (54.38s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (54.46s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_defaultOnly (59.58s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (60.66s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (78.02s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (96.30s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (102.25s)

The output from acceptance testing on commercial:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (15.47s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (19.52s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_defaultOnly (203.34s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (446.33s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (453.16s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (455.84s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (456.21s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (462.88s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (469.54s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (482.06s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (498.31s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (616.16s)

@YakDriver YakDriver requested a review from a team September 17, 2020 20:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 17, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Sep 17, 2020
@YakDriver YakDriver force-pushed the f-d-rds-orderable-instance branch from ab7a9e4 to 280f42a Compare September 17, 2020 20:13
This was referenced Sep 17, 2020
Closed
Closed
Closed
bflad
bflad previously requested changes Sep 18, 2020
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor adjustments then should be good to go. 👍

Comment thread aws/data_source_aws_rds_orderable_db_instance.go Outdated
Comment thread aws/data_source_aws_rds_orderable_db_instance.go Outdated
Comment thread aws/data_source_aws_rds_orderable_db_instance.go Outdated
Comment thread website/docs/d/rds_orderable_db_instance.markdown Outdated
@YakDriver YakDriver force-pushed the f-d-rds-orderable-instance branch 2 times, most recently from 92626c1 to fe5f7d2 Compare September 18, 2020 15:50
@YakDriver YakDriver dismissed bflad’s stale review September 18, 2020 15:54

Changes made! 👍

@YakDriver YakDriver changed the title d/rds_orderable_db_instance: Enable default only version d/rds_orderable_db_instance: Enable default only version if no version Sep 18, 2020
@YakDriver YakDriver changed the title d/rds_orderable_db_instance: Enable default only version if no version d/rds_orderable_db_instance: Prioritize the default engine version if none is given Sep 18, 2020
@YakDriver YakDriver force-pushed the f-d-rds-orderable-instance branch from fe5f7d2 to d1dfcd0 Compare September 18, 2020 17:52
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 18, 2020
@YakDriver YakDriver mentioned this pull request Sep 18, 2020
Closed
@YakDriver YakDriver marked this pull request as draft September 18, 2020 22:40
@YakDriver YakDriver changed the title d/rds_orderable_db_instance: Prioritize the default engine version if none is given d/rds_orderable_db_instance: Add documentation for argument Sep 21, 2020
@YakDriver YakDriver force-pushed the f-d-rds-orderable-instance branch 2 times, most recently from 2673b56 to 63d066e Compare September 21, 2020 18:28
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Sep 21, 2020
YakDriver
YakDriver commented Sep 21, 2020
View reviewed changes
Comment thread aws/data_source_aws_rds_orderable_db_instance_test.go Outdated
@YakDriver YakDriver marked this pull request as ready for review September 21, 2020 18:40
@YakDriver YakDriver requested a review from bflad September 21, 2020 18:44
@YakDriver YakDriver force-pushed the f-d-rds-orderable-instance branch from 63d066e to 20c721e Compare September 21, 2020 18:54
@YakDriver

YakDriver commented Sep 21, 2020

Copy link
Copy Markdown
Member Author

I'm not sure if it's the new precheck or something on the AWS side but these tests are running much faster.

GovCloud:

--- SKIP: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (3.18s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (16.83s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (16.87s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (48.99s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (52.76s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (55.27s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (63.01s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (66.03s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (69.15s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (70.75s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (121.45s)

Commercial:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (12.45s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (13.57s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (177.71s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (178.27s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (180.31s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (180.33s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (181.29s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (183.61s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (185.52s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (187.74s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (279.49s)

This was referenced Sep 21, 2020
Closed
Closed
bflad
bflad approved these changes Sep 23, 2020
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (15.88s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (15.91s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (158.67s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (162.02s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (166.30s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (166.63s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (167.13s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (169.59s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (170.05s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (183.47s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (260.46s)

Comment thread aws/data_source_aws_rds_orderable_db_instance_test.go Outdated
@bflad bflad self-assigned this Sep 23, 2020
@YakDriver YakDriver added this to the v3.8.0 milestone Sep 23, 2020
@YakDriver YakDriver merged commit 6b7efc6 into master Sep 23, 2020
@YakDriver YakDriver deleted the f-d-rds-orderable-instance branch September 23, 2020 19:44
@ghost

ghost commented Sep 24, 2020

Copy link
Copy Markdown

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost

ghost commented Oct 24, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bflad bflad

Labels

documentation Introduces or discusses updates to documentation. partition/aws-us-gov Pertains to the aws-us-gov partition. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

d/rds_orderable_db_instance: Add documentation for argument

2 participants

@YakDriver @bflad
⚡