resource/aws_ebs_volume: Allow both 'snapshot_id' and 'size'

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17235.
Relates #16514.
Relates #16517.

Includes formatting fix from #17242.

Verified that at least one of size or snapshot_id is required:

$ aws --region us-west-2 ec2 create-volume --availability-zone us-west-2a

An error occurred (MissingParameter) when calling the CreateVolume operation: The request must contain the parameter size/snapshot

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_ -timeout 120m
=== RUN   TestAccAWSEBSVolume_basic
=== PAUSE TestAccAWSEBSVolume_basic
=== RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
=== PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
=== RUN   TestAccAWSEBSVolume_updateSize
=== PAUSE TestAccAWSEBSVolume_updateSize
=== RUN   TestAccAWSEBSVolume_updateType
=== PAUSE TestAccAWSEBSVolume_updateType
=== RUN   TestAccAWSEBSVolume_updateIops_Io1
=== PAUSE TestAccAWSEBSVolume_updateIops_Io1
=== RUN   TestAccAWSEBSVolume_updateIops_Io2
=== PAUSE TestAccAWSEBSVolume_updateIops_Io2
=== RUN   TestAccAWSEBSVolume_kmsKey
=== PAUSE TestAccAWSEBSVolume_kmsKey
=== RUN   TestAccAWSEBSVolume_NoIops
=== PAUSE TestAccAWSEBSVolume_NoIops
=== RUN   TestAccAWSEBSVolume_InvalidIopsForType
=== PAUSE TestAccAWSEBSVolume_InvalidIopsForType
=== RUN   TestAccAWSEBSVolume_InvalidThroughputForType
=== PAUSE TestAccAWSEBSVolume_InvalidThroughputForType
=== RUN   TestAccAWSEBSVolume_withTags
=== PAUSE TestAccAWSEBSVolume_withTags
=== RUN   TestAccAWSEBSVolume_multiAttach
=== PAUSE TestAccAWSEBSVolume_multiAttach
=== RUN   TestAccAWSEBSVolume_outpost
=== PAUSE TestAccAWSEBSVolume_outpost
=== RUN   TestAccAWSEBSVolume_gp3_basic
=== PAUSE TestAccAWSEBSVolume_gp3_basic
=== RUN   TestAccAWSEBSVolume_gp3_iops
=== PAUSE TestAccAWSEBSVolume_gp3_iops
=== RUN   TestAccAWSEBSVolume_gp3_throughput
=== PAUSE TestAccAWSEBSVolume_gp3_throughput
=== RUN   TestAccAWSEBSVolume_snapshotID
=== PAUSE TestAccAWSEBSVolume_snapshotID
=== RUN   TestAccAWSEBSVolume_snapshotIDAndSize
=== PAUSE TestAccAWSEBSVolume_snapshotIDAndSize
=== RUN   TestAccAWSEBSVolume_disappears
=== PAUSE TestAccAWSEBSVolume_disappears
=== CONT  TestAccAWSEBSVolume_basic
=== CONT  TestAccAWSEBSVolume_withTags
=== CONT  TestAccAWSEBSVolume_disappears
=== CONT  TestAccAWSEBSVolume_snapshotIDAndSize
=== CONT  TestAccAWSEBSVolume_snapshotID
=== CONT  TestAccAWSEBSVolume_gp3_throughput
=== CONT  TestAccAWSEBSVolume_gp3_iops
=== CONT  TestAccAWSEBSVolume_gp3_basic
=== CONT  TestAccAWSEBSVolume_outpost
=== CONT  TestAccAWSEBSVolume_multiAttach
=== CONT  TestAccAWSEBSVolume_updateIops_Io2
=== CONT  TestAccAWSEBSVolume_InvalidThroughputForType
=== CONT  TestAccAWSEBSVolume_InvalidIopsForType
=== CONT  TestAccAWSEBSVolume_NoIops
=== CONT  TestAccAWSEBSVolume_kmsKey
=== CONT  TestAccAWSEBSVolume_updateType
=== CONT  TestAccAWSEBSVolume_updateIops_Io1
=== CONT  TestAccAWSEBSVolume_updateSize
=== CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
=== CONT  TestAccAWSEBSVolume_outpost
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSEBSVolume_outpost (2.98s)
--- PASS: TestAccAWSEBSVolume_InvalidThroughputForType (20.53s)
--- PASS: TestAccAWSEBSVolume_InvalidIopsForType (20.60s)
--- PASS: TestAccAWSEBSVolume_disappears (57.32s)
--- PASS: TestAccAWSEBSVolume_NoIops (65.27s)
--- PASS: TestAccAWSEBSVolume_multiAttach (72.48s)
--- PASS: TestAccAWSEBSVolume_withTags (72.54s)
--- PASS: TestAccAWSEBSVolume_basic (72.60s)
--- PASS: TestAccAWSEBSVolume_gp3_basic (73.47s)
--- PASS: TestAccAWSEBSVolume_kmsKey (74.54s)
--- PASS: TestAccAWSEBSVolume_snapshotIDAndSize (80.58s)
--- PASS: TestAccAWSEBSVolume_snapshotID (84.31s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io2 (84.79s)
--- PASS: TestAccAWSEBSVolume_updateType (97.39s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io1 (100.53s)
--- PASS: TestAccAWSEBSVolume_gp3_throughput (101.28s)
--- PASS: TestAccAWSEBSVolume_updateSize (101.72s)
--- PASS: TestAccAWSEBSVolume_gp3_iops (102.74s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (189.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	190.076s

[bflad]

Looks good to me, @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_basic (33.48s)
--- PASS: TestAccAWSEBSVolume_disappears (30.44s)
--- PASS: TestAccAWSEBSVolume_gp3_basic (33.48s)
--- PASS: TestAccAWSEBSVolume_gp3_iops (60.35s)
--- PASS: TestAccAWSEBSVolume_gp3_throughput (59.52s)
--- PASS: TestAccAWSEBSVolume_InvalidIopsForType (4.53s)
--- PASS: TestAccAWSEBSVolume_InvalidThroughputForType (4.49s)
--- PASS: TestAccAWSEBSVolume_kmsKey (37.88s)
--- PASS: TestAccAWSEBSVolume_multiAttach (34.63s)
--- PASS: TestAccAWSEBSVolume_NoIops (33.46s)
--- PASS: TestAccAWSEBSVolume_snapshotID (65.05s)
--- PASS: TestAccAWSEBSVolume_snapshotIDAndSize (64.66s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (275.15s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io1 (60.24s)
--- PASS: TestAccAWSEBSVolume_updateIops_Io2 (60.25s)
--- PASS: TestAccAWSEBSVolume_updateSize (60.33s)
--- PASS: TestAccAWSEBSVolume_updateType (60.81s)
--- PASS: TestAccAWSEBSVolume_withTags (33.96s)
--- SKIP: TestAccAWSEBSVolume_outpost (2.00s)

[ghost]

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!