Skip to content

Add Auto Scaling Plans service client#8962

Merged
bflad merged 1 commit into
hashicorp:masterfrom
ewbankkit:add-autoscalingplans-service-client
Jun 12, 2019
Merged

Add Auto Scaling Plans service client#8962
bflad merged 1 commit into
hashicorp:masterfrom
ewbankkit:add-autoscalingplans-service-client

Conversation

@ewbankkit

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Prerequisite for #6562.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSProvider_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSProvider_ -timeout 120m
=== RUN   TestAccAWSProvider_Endpoints
=== PAUSE TestAccAWSProvider_Endpoints
=== RUN   TestAccAWSProvider_Endpoints_Deprecated
=== PAUSE TestAccAWSProvider_Endpoints_Deprecated
=== CONT  TestAccAWSProvider_Endpoints
=== CONT  TestAccAWSProvider_Endpoints_Deprecated
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.10s)
--- PASS: TestAccAWSProvider_Endpoints (3.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.223s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 12, 2019
@bflad

bflad commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

Thanks so much, @ewbankkit 🚀 LGTM

@bflad bflad added this to the v2.15.0 milestone Jun 12, 2019
@bflad bflad merged commit 5d14dd3 into hashicorp:master Jun 12, 2019
@ewbankkit ewbankkit deleted the add-autoscalingplans-service-client branch June 12, 2019 20:08
@ghost

ghost commented Nov 3, 2019

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants