Allow creation of everlasting spot fleet requests#9718
Merged
Conversation
ghost
added
size/XS
According to the AWS API doc, if `valid until` is _not_ set, then the spot fleet request "remains until you cancel it". By having a 24 hr default, then this behaviour cannot be achieved using this terraform provider - so the default it removed. Some conversation about the default: hashicorp@5bafd4b#r34628957 The relevant AWS doc: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SpotFleetRequestConfigData.html
jkburges
force-pushed
the
make-valid-until-optional
branch
from
26ef750 to
a005a97
Compare
Contributor
Author
|
I have no idea why |
|
I just got bit by this as well. It is an odd arbitrary default value and leads to workaround like this: https://www.reddit.com/r/aws/comments/8t3373/whats_up_with_spot_fleet_request_valid_until/e14ilye/ Can we tickle this PR so the review bot will look at it again? The logs from the previous run are gone. |
Contributor
Author
I am currently trying to figure out how to do this. |
jkburges
force-pushed
the
make-valid-until-optional
branch
from
a190732 to
a005a97
Compare
bflad
added
breaking-change
bflad
approved these changes
Jul 13, 2020
bflad
left a comment
bflad
left a comment
Contributor
There was a problem hiding this comment.
LGTM after fixing the merge conflict, thanks @jkburges 🚀
Output from acceptance testing:
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (113.80s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (113.50s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (235.61s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (442.58s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (262.34s)
--- PASS: TestAccAWSSpotFleetRequest_basic (594.58s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (886.41s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (606.81s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (297.72s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (596.52s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (600.46s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (377.27s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (572.48s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (316.61s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (511.71s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (274.95s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (225.88s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (223.90s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (595.91s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (222.91s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (370.43s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (295.97s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (272.91s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (315.56s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (58.75s)
--- PASS: TestAccAWSSpotFleetRequest_tags (312.62s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (814.76s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (878.48s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (595.56s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (597.37s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (304.19s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (282.35s)
bflad
added a commit
that referenced
this pull request
Jul 13, 2020
… 3 upgrade guide Reference: #9718
bflad
added a commit
that referenced
this pull request
Jul 14, 2020
|
This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the AWS API doc, if
valid untilis not set, then the spot fleet request "remains until you cancel it". By having a 24 hr default, then this behaviour cannot be achieved using this terraform provider - so the default it removed.Some conversation about the default: 5bafd4b#r34628957
The relevant AWS doc: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_SpotFleetRequestConfigData.html
Community Note
Release note for CHANGELOG: