feat: add sensitive_request_headers argument#521
Conversation
|
|
This seeks to address issue hashicorp#34 via `sensitive_request_headers`, which serves the same function as `request_headers`, but are denoted as sensitive and their values are obscured as `*****` in Terraform state. Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
force-pushed
the
mdb/sensitive-request-headers
branch
from
e1b4a01 to
0d4aa69
Compare
| if strings.ToLower(name) == "host" { | ||
| request.Host = header | ||
| } | ||
| } |
There was a problem hiding this comment.
☝️ This and the line 348 loop could probably be DRY'd up :)
|
Hi @mdb 👋
Does wrapping your secret value in |
|
Hi @ansgarm - Thanks for the response!
I don't believe so;
|
|
Hi @mdb – yes, that PR looks like something we'd rather accept to solve this problem. I'm going to share your new PR with the team to discuss it the next time we meet to discuss the utility providers. So bear with us for another ~week until we get back to you on this. Thank you for all your work on this so far! In the meantime I'm going to close this PR in favor of your other one. |
2 participants
This seeks to address issue #34 via
sensitive_request_headers, which serves the same function asrequest_headers, butsensitive_request_headersare denoted as sensitive and their values are obscured as*****in Terraform state.