Skip to content

Add Diagnostic when determining Terraform type fails#2018

Merged
jrhouston merged 15 commits intomainfrom
add-diag-prestop
Mar 13, 2023
Merged

Add Diagnostic when determining Terraform type fails#2018
jrhouston merged 15 commits intomainfrom
add-diag-prestop

Conversation

@BBBmau
Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau commented Feb 24, 2023 •
edited by jrhouston
Loading

Description

Outputs a better error message than what was previously shown if their was an issue with determining a TF type from manifest

Related to #1950

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner February 24, 2023 19:35
@BBBmau BBBmau mentioned this pull request Feb 25, 2023
Open
jrhouston
jrhouston requested changes Feb 27, 2023
View reviewed changes
Comment thread manifest/morph/morph.go Outdated
@github-actions github-actions bot added size/L and removed size/XS labels Feb 28, 2023
jrhouston
jrhouston requested changes Feb 28, 2023
View reviewed changes
Comment thread manifest/morph/morph.go Outdated
@github-actions github-actions bot added size/M and removed size/L labels Feb 28, 2023
jrhouston
jrhouston requested changes Mar 6, 2023
View reviewed changes
Comment thread manifest/morph/morph.go Outdated
Comment thread manifest/morph/morph.go Outdated
jrhouston
jrhouston reviewed Mar 7, 2023
View reviewed changes
Comment thread manifest/morph/morph.go Outdated
@github-actions github-actions bot added size/XL and removed size/M labels Mar 8, 2023
jrhouston
jrhouston reviewed Mar 13, 2023
View reviewed changes
Comment thread kubernetes/test-infra/aks-new/.tool-versions Outdated
jrhouston
jrhouston requested changes Mar 13, 2023
View reviewed changes
Comment thread manifest/morph/morph.go Outdated
@github-actions github-actions bot removed the size/XL label Mar 13, 2023
@BBBmau BBBmau requested a review from jrhouston March 13, 2023 17:00
jrhouston
jrhouston approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BBBmau 🚀

@jrhouston jrhouston merged commit 1108ceb into main Mar 13, 2023
@jrhouston jrhouston deleted the add-diag-prestop branch March 13, 2023 19:49
@BBBmau BBBmau mentioned this pull request Mar 14, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jrhouston jrhouston jrhouston approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BBBmau @jrhouston
⚡