Open
Conversation
Resolves an issue in the musb handle_xfer_out function where not all execution paths cleared the MUSB_RXCSRL1_RXRDY bit, causing the RX interface to hang and no longer communicate with the host. Signed-off-by: Brent Kowal <brent.kowal@analog.com>
BrentK-ADI
force-pushed
the
musb_rx_fifo_fixes
branch
from
248303e to
ed37ad8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue in the musb
handle_xfer_outfunction where not all execution paths cleared theMUSB_RXCSRL1_RXRDYbit, causing the RX interface to hang and no longer communicate with the host.This issue was discovered while using the RNDIS class in a media converter application. When running iperf testing at full speed (10Mbps link) the USB stack was under constant load of packets and eventually would stop receiving new frames from the host PC. Other USB events and interrupts were still occurring.
It is believed the root cause was the RXRDY bit not being cleared in all data paths of the xfer handler, resulting in the peripheral no longer accepting new frames into the FIFO. Applying this change allowed continuous operation under these high traffic conditions without lockup.
Verification Testing
Testing was performed with 2x MAX32690's acting as RNDIS to 10Mbps single pair ethernet media converters, connected to Linux PCs. Bidirectional iperf was run for 12 hours resulting in each MCU sending and receiving 18M+ packets (~24 GB) in each direction with no driver lock ups of failures. Prior to these updates, testing would fail within minutes.