Skip to content

narrow#5

Closed
hauntsaninja wants to merge 10 commits intomasterfrom
narrowdev
Closed

narrow#5
hauntsaninja wants to merge 10 commits intomasterfrom
narrowdev

Conversation

@hauntsaninja
Copy link
Copy Markdown
Owner

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@hauntsaninja hauntsaninja force-pushed the narrowdev branch 3 times, most recently from dc3611a to 243276d Compare January 12, 2026 09:22
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@hauntsaninja hauntsaninja force-pushed the narrowdev branch 5 times, most recently from a58b9cc to 72e879e Compare January 24, 2026 07:03
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

Diff from mypy_primer, showing the effect of this PR on open source code:

spark (https://github.com/apache/spark)
- python/pyspark/mllib/regression.py:282: error: Unused "type: ignore" comment  [unused-ignore]
- python/pyspark/mllib/regression.py:282: error: Incompatible return value type (got "LogisticRegressionModel", expected "LM")  [return-value]
- python/pyspark/mllib/regression.py:282: note: Error code "return-value" not covered by "type: ignore" comment

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/server/api/server.py:664: error: Invalid index type "tuple[str, bool, bool]" for "dict[tuple[Settings, bool], Any]"; expected type "tuple[Settings, bool]"  [index]

pydantic (https://github.com/pydantic/pydantic)
+ pydantic/v1/typing.py:236: error: Unused "type: ignore" comment  [unused-ignore]
+ pydantic/networks.py:244: error: Incompatible return value type (got "SupportsBool", expected "bool")  [return-value]
+ pydantic/networks.py:247: error: Incompatible return value type (got "SupportsBool", expected "bool")  [return-value]
+ pydantic/networks.py:250: error: Incompatible return value type (got "SupportsBool", expected "bool")  [return-value]
+ pydantic/networks.py:253: error: Incompatible return value type (got "SupportsBool", expected "bool")  [return-value]

mypy (https://github.com/python/mypy)
+ mypy/server/objgraph.py:69: error: Left operand of "and" is always true  [redundant-expr]
+ mypy/server/objgraph.py:69: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-redundant-expr for more info
+ mypy/server/aststrip.py:140: error: If condition in comprehension is always true  [redundant-expr]
+ mypy/server/aststrip.py:140: note: Error code "redundant-expr" not covered by "type: ignore" comment
+ mypy/server/astmerge.py:165: error: Right operand of "and" is never evaluated  [unreachable]
+ mypy/server/astmerge.py:171: error: Statement is unreachable  [unreachable]
+ mypy/server/astmerge.py:171: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-unreachable for more info
+ mypy/stubutil.py:76: error: Statement is unreachable  [unreachable]
+ mypy/stubtest.py:701: error: Statement is unreachable  [unreachable]

graphql-core (https://github.com/graphql-python/graphql-core)
- tests/execution/test_resolve.py:322: error: Value of type "list[SourceLocation] | None" is not indexable  [index]

zulip (https://github.com/zulip/zulip)
- analytics/views/stats.py:577: error: Incompatible return value type (got "QuerySet[RealmCount, RealmCount]", expected "QuerySet[CountT, CountT]")  [return-value]
- analytics/views/stats.py:579: error: Incompatible return value type (got "QuerySet[UserCount, UserCount]", expected "QuerySet[CountT, CountT]")  [return-value]
- analytics/views/stats.py:581: error: Incompatible return value type (got "QuerySet[StreamCount, StreamCount]", expected "QuerySet[CountT, CountT]")  [return-value]
- analytics/views/stats.py:583: error: Incompatible return value type (got "QuerySet[InstallationCount, InstallationCount]", expected "QuerySet[CountT, CountT]")  [return-value]
- analytics/views/stats.py:585: error: Incompatible return value type (got "QuerySet[RemoteInstallationCount, RemoteInstallationCount]", expected "QuerySet[CountT, CountT]")  [return-value]
- analytics/views/stats.py:587: error: Incompatible return value type (got "QuerySet[RemoteRealmCount, RemoteRealmCount]", expected "QuerySet[CountT, CountT]")  [return-value]

operator (https://github.com/canonical/operator)
- ops/_private/harness.py:2563: error: Invalid index type "str" for "dict[int, dict[str, Any]]"; expected type "int"  [index]

core (https://github.com/home-assistant/core)
+ homeassistant/helpers/config_validation.py:705: error: Returning Any from function declared to return "str"  [no-any-return]
+ homeassistant/components/homekit/__init__.py:982: error: Right operand of "or" is never evaluated  [unreachable]
+ homeassistant/components/philips_js/media_player.py:203: error: Argument 1 to "get_browse_image_url" of "MediaPlayerEntity" has incompatible type "str | None"; expected "str"  [arg-type]
+ homeassistant/components/isy994/sensor.py:206: error: Argument 2 to "temperature" of "UnitSystem" has incompatible type "str | None"; expected "str"  [arg-type]

pytest (https://github.com/pytest-dev/pytest)
+ src/_pytest/raises.py:1486: error: Unused "type: ignore" comment  [unused-ignore]
+ testing/test_capture.py:923: error: Statement is unreachable  [unreachable]

rich (https://github.com/Textualize/rich)
+ rich/console.py:1540: error: Redundant cast to "Literal['left', 'center', 'right']"  [redundant-cast]

pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/arrays/datetimes.py:2997: error: Unused "type: ignore" comment  [unused-ignore]
+ pandas/core/arrays/datetimes.py:3009: error: Unused "type: ignore" comment  [unused-ignore]
+ pandas/core/arrays/datetimes.py:3011: error: Redundant cast to "Timestamp"  [redundant-cast]
+ pandas/core/arrays/datetimes.py:3012: error: Redundant cast to "Timestamp"  [redundant-cast]
- pandas/core/indexes/datetimelike.py:279: error: Unused "type: ignore" comment  [unused-ignore]

discord.py (https://github.com/Rapptz/discord.py)
- discord/channel.py:3048: error: Argument "stickers" to "handle_message_parameters" has incompatible type "Sequence[GuildSticker | StickerItem]"; expected "list[str | int] | None"  [arg-type]
+ discord/channel.py:3048: error: Argument "stickers" to "handle_message_parameters" has incompatible type "Sequence[Any]"; expected "list[str | int] | None"  [arg-type]
- discord/webhook/sync.py:1105: error: Argument "applied_tags" to "handle_message_parameters" has incompatible type "str | Snowflake"; expected "list[str | int] | None"  [arg-type]
+ discord/webhook/sync.py:1105: error: Cannot determine type of "applied_tag_ids"  [has-type]
- discord/webhook/async_.py:1892: error: Argument "applied_tags" to "handle_message_parameters" has incompatible type "str | Snowflake"; expected "list[str | int] | None"  [arg-type]
+ discord/webhook/async_.py:1892: error: Cannot determine type of "applied_tag_ids"  [has-type]

trio (https://github.com/python-trio/trio)
+ src/trio/_core/_local.py:54: error: Unused "type: ignore" comment  [unused-ignore]
+ src/trio/_core/_local.py:57: error: Unused "type: ignore" comment  [unused-ignore]
+ src/trio/_tests/test_socket.py:1116: error: Unused "type: ignore" comment  [unused-ignore]
+ src/trio/_core/_tests/test_run.py:2457: error: Unused "type: ignore" comment  [unused-ignore]

dulwich (https://github.com/dulwich/dulwich)
+ dulwich/server.py:949: error: Argument 1 to "unread_proto_line" of "_ProtocolGraphWalker" has incompatible type "bytes | None"; expected "bytes"  [arg-type]

black (https://github.com/psf/black)
- src/blib2to3/pytree.py:84:9: error: Returning Any from function declared to return "bool"  [no-any-return]

Expression (https://github.com/cognitedata/Expression)
- README.py:460: error: Incompatible types in assignment (expression has type "Result[int, Exception]", variable has type "Seq[int]")  [assignment]

pyodide (https://github.com/pyodide/pyodide)
+ pyodide-build/pyodide_build/tests/test_xbuildenv.py:88: error: Statement is unreachable  [unreachable]

rotki (https://github.com/rotki/rotki)
+ rotkehlchen/exchanges/binance.py:391: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/integration/test_premium.py:820: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/integration/test_premium.py:834: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/api/test_settings.py:641: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/api/test_evmlike.py:212: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/api/blockchain/test_bitcoin.py:42: error: Statement is unreachable  [unreachable]
+ rotkehlchen/tests/api/test_history_base_entry.py:1263: error: Need type annotation for "ids_per_subtype"  [var-annotated]

static-frame (https://github.com/static-frame/static-frame)
+ static_frame/core/type_blocks.py:1633: error: Unused "type: ignore" comment  [unused-ignore]
+ static_frame/core/type_blocks.py:1634: error: Unused "type: ignore" comment  [unused-ignore]
+ static_frame/core/type_blocks.py:1759: error: Unused "type: ignore" comment  [unused-ignore]
+ static_frame/core/type_blocks.py:1760: error: Unused "type: ignore" comment  [unused-ignore]
+ static_frame/core/archive_npy.py:231: error: Statement is unreachable  [unreachable]
+ static_frame/core/interface.py:1041: error: Statement is unreachable  [unreachable]
+ static_frame/core/interface.py:1043: error: Statement is unreachable  [unreachable]
+ static_frame/core/interface.py:1066: error: Item "type" of "type[InterfaceValues[TVContainer_co@InterfaceValues]] | type[InterfaceString[TVContainer_co@InterfaceString]] | type[InterfaceDatetime[TVContainer_co@InterfaceDatetime]] | type[InterfaceTranspose[TVContainer_co@InterfaceTranspose]] | type[InterfaceFillValue[TVContainer_co@InterfaceFillValue]] | type[InterfaceRe[TVContainer_co@InterfaceRe]] | type[ReduceDispatch] | type[<subclass of "static_frame.core.node_selector.Interface" and "typing.Mapping[Any, Any]">]" has no attribute "CLS_DELEGATE"  [union-attr]
+ static_frame/core/interface.py:1576: error: Statement is unreachable  [unreachable]
+ static_frame/core/interface.py:1581: error: Statement is unreachable  [unreachable]
+ static_frame/core/interface.py:1586: error: Statement is unreachable  [unreachable]

cloud-init (https://github.com/canonical/cloud-init)
+ tests/unittests/sources/test_maas.py:269: error: Statement is unreachable  [unreachable]
+ tests/unittests/cmd/test_status.py:260: error: Statement is unreachable  [unreachable]

artigraph (https://github.com/artigraph/artigraph)
+ src/arti/views/__init__.py:98: error: Incompatible types in assignment (expression has type "type[View] | None", variable has type "type[Self]")  [assignment]
+ src/arti/views/__init__.py:102: error: Incompatible types in assignment (expression has type "type[View] | None", variable has type "type[Self]")  [assignment]
+ tests/arti/producers/test_producer.py:62: error: Unused "type: ignore" comment  [unused-ignore]
+ tests/arti/producers/test_producer.py:63: error: Unused "type: ignore" comment  [unused-ignore]
+ tests/arti/producers/test_producer.py:79: error: Unused "type: ignore" comment  [unused-ignore]
+ tests/arti/producers/test_producer.py:80: error: Unused "type: ignore" comment  [unused-ignore]
+ tests/arti/producers/test_producer.py:118: error: Unused "type: ignore[empty-body]" comment  [unused-ignore]
+ tests/arti/producers/test_producer.py:129: error: Unused "type: ignore[empty-body]" comment  [unused-ignore]

xarray (https://github.com/pydata/xarray)
+ xarray/core/extension_array.py: note: In function "union_unordered_categorical_and_scalar":
+ xarray/core/extension_array.py:163: error: If condition in comprehension is always true  [redundant-expr]
+ xarray/indexes/nd_point_index.py: note: In member "from_variables" of class "NDPointIndex":
+ xarray/indexes/nd_point_index.py:271: error: Incompatible types in assignment (expression has type "type[ScipyKDTreeAdapter]", variable has type "type[T_TreeAdapter]")  [assignment]
+ xarray/tests/test_dataarray.py:291: error: Unused "type: ignore" comment  [unused-ignore]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant