Security: Cross-window messaging uses wildcard target origin#499
Open
tuanaiseo wants to merge 1 commit intohediet:mainfrom
Open
Conversation
Plugin messaging sends data with `postMessage(..., "*")`, which does not constrain recipients by origin. Sensitive actions/events (including command invocation flows) can be exposed to unintended origins if window relationships change or are abused. Affected files: vscode.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Plugin messaging sends data with
postMessage(..., "*"), which does not constrain recipients by origin. Sensitive actions/events (including command invocation flows) can be exposed to unintended origins if window relationships change or are abused.Severity:
highFile:
drawio-custom-plugins/src/vscode.tsSolution
Use a strict expected origin instead of
"*", and enforce origin checks on both senders and receivers.Changes
drawio-custom-plugins/src/vscode.ts(modified)Testing