Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/external-dns]Fix typo in values-production#15352

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
carrodher:external
Jul 9, 2019
Merged

[stable/external-dns]Fix typo in values-production#15352
k8s-ci-robot merged 1 commit intohelm:masterfrom
carrodher:external

Conversation

@carrodher
Copy link
Copy Markdown
Collaborator

Signed-off-by: Carlos Rodriguez Hernandez crhernandez@bitnami.com

What this PR does / why we need it:

Fix a typo in the values-production:

$ helm template . -f values-production.yaml --name foobar
Error: failed to parse values-production.yaml: error converting YAML to JSON: yaml: line 288: did not find expected key

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from juan131 and tompizmor July 9, 2019 14:13
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
Copy link
Copy Markdown
Collaborator

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @carrodher

@juan131
Copy link
Copy Markdown
Collaborator

juan131 commented Jul 9, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. ok-to-test labels Jul 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carrodher, juan131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ebd6703 into helm:master Jul 9, 2019
@carrodher carrodher deleted the external branch July 10, 2019 10:25
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants