Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/rethinkdb] Implement storageClass#21750

Merged
k8s-ci-robot merged 2 commits intohelm:masterfrom
fernferret:f-storage-class
Apr 20, 2020
Merged

[stable/rethinkdb] Implement storageClass#21750
k8s-ci-robot merged 2 commits intohelm:masterfrom
fernferret:f-storage-class

Conversation

@fernferret
Copy link
Copy Markdown
Contributor

@fernferret fernferret commented Apr 3, 2020

The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

@meenie

Is this a new chart

No

What this PR does / why we need it:

The cluster.persistentVolume.storageClass was documented but never used/implemented.

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@fernferret
[stable/rethinkdb] Fixed storageClass
022494d 
The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

Signed-off-by: Eric Stokes <fernferret@gmail.com>
@fernferret
bumped chart version
447beac 
Signed-off-by: Eric Stokes <fernferret@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 3, 2020

Hi @fernferret. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fernferret fernferret changed the title F storage class [stable/rethinkdb] Implement storageClass Apr 3, 2020
@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Apr 14, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
meenie
meenie approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@meenie meenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zanhsieh
Copy link
Copy Markdown
Collaborator

zanhsieh commented Apr 16, 2020

@lachie83
@prydonius
@sameersbn
@viglesiasce
@unguiculus
@scottrigby
@mattfarina
@davidkarlsen
@paulczar
@cpanato
@jlegrone
@maorfr
Could you guys lgtm this please?

@maorfr
Copy link
Copy Markdown
Member

maorfr commented Apr 20, 2020

/lgtm

would you mind avoiding such mass pings?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FernFerret, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit a2c3703 into helm:master Apr 20, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@fernferret
[stable/rethinkdb] Implement storageClass (helm#21750)
5874c91 
* [stable/rethinkdb] Fixed storageClass

The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

Signed-off-by: Eric Stokes <fernferret@gmail.com>

* bumped chart version

Signed-off-by: Eric Stokes <fernferret@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@fernferret @includerandom
[stable/rethinkdb] Implement storageClass (helm#21750)
72c519e 
* [stable/rethinkdb] Fixed storageClass

The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

Signed-off-by: Eric Stokes <fernferret@gmail.com>

* bumped chart version

Signed-off-by: Eric Stokes <fernferret@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@fernferret @li-adrienloiseau
[stable/rethinkdb] Implement storageClass (helm#21750)
ec9fd3f 
* [stable/rethinkdb] Fixed storageClass

The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

Signed-off-by: Eric Stokes <fernferret@gmail.com>

* bumped chart version

Signed-off-by: Eric Stokes <fernferret@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@fernferret
[stable/rethinkdb] Implement storageClass (helm#21750)
903be00 
* [stable/rethinkdb] Fixed storageClass

The cluster.persistentVolume.storageClass was never used and would never
properly populate the volumeClaimTemplate.

This also adds the convention that "-" will set the null storage class
(as this is a pretty common convention).

Signed-off-by: Eric Stokes <fernferret@gmail.com>

* bumped chart version

Signed-off-by: Eric Stokes <fernferret@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@unguiculus unguiculus Awaiting requested review from unguiculus

1 more reviewer

@meenie meenie meenie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fernferret @k8s-ci-robot @zanhsieh @maorfr @meenie @helm-bot
⚡