Readme: Add direkt FAQ link.#538
Merged
Merged
Conversation
Member
|
I'll take a look at this. However, I think it might be better to link to the main Helmet docs site rather than linking to the FAQ specifically...not sure.
|
EvanHahn
requested changes
May 10, 2026
EvanHahn
left a comment
EvanHahn
left a comment
Member
There was a problem hiding this comment.
I think this is good, but I think it'd be better if it linked to the docs site directly. Could you update it to link to that?
mk-pmb
force-pushed
the
pr-readme-faq-link
branch
from
c1eeacb to
2c153e3
Compare
Contributor
Author
|
I added the direct docs link and kept the "FAQ" and "question" keywords for now. If with "rather than" you meant to drop them, that wasn't clear enough, since we can have both at almost no cost. |
Member
|
Thanks, I'll take another look at this in the next couple of weeks.
|
EvanHahn
approved these changes
May 16, 2026
Member
|
I made a few tweaks and merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if I search https://github.com/helmetjs/helmet for "faq" or "question", there's no match at all.