Add standard module path compatibility to extras/modules#262
Open
Pandapip1 wants to merge 1 commit intohercules-ci:mainfrom
Open
Add standard module path compatibility to extras/modules#262Pandapip1 wants to merge 1 commit intohercules-ci:mainfrom
Pandapip1 wants to merge 1 commit intohercules-ci:mainfrom
Conversation
Pandapip1
force-pushed
the
modules-copyover
branch
from
b703854 to
4942a7d
Compare
roberth
reviewed
Dec 8, 2024
| }; | ||
| config = { | ||
| # Copy over to old nixosModules and hmModules attributes | ||
| flake = { |
Member
There was a problem hiding this comment.
I'm a little wary of conditional attributes in the flake option, because the condition will have to be evaluated before self and self.outPath become accessible, producing an infinite recursion otherwise. (Fixing this for self.outPath needs a more or less breaking change in flakes / call-flake.nix)
In most cases this would be fine, but in the few where it's not, it produces an almost incomprehensible error.
With that in mind, it'd be safer to make this a module that users import separately.
Author
There was a problem hiding this comment.
Instead of a separate module that has to be imported, would an option that disables the behavior an okay compromise?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.