Merged
Conversation
joshwlewis
reviewed
May 6, 2024
Registers an exec.d program that: - configures the npm `cache` to write to a temporary directory - disables the npm `update-notifier`
edmorley
reviewed
May 7, 2024
joshwlewis
reviewed
May 7, 2024
edmorley
reviewed
May 13, 2024
Member
edmorley
left a comment
edmorley
left a comment
There was a problem hiding this comment.
The env var approach looks good to me :-)
Leaving the main review to Josh.
* main: Prepare release v3.2.2 (#848) Update Inventory for heroku/nodejs (#846) Fix failing integration test (#847) Update Node functions runtime to 0.14.5 (#845) Update Inventory for heroku/nodejs-npm-engine (#842) Update Inventory for heroku/nodejs (#844) Fix Node.js inventory automation (#843) Adding Heroku-24 to CI test matrix (#841) Node.js inventory updates with Keep a Changelog format (#840) Fixed the changelog to follow the Keep a Changelog spec properly (#839) # Conflicts: # buildpacks/nodejs-npm-install/CHANGELOG.md # buildpacks/nodejs-npm-install/tests/integration_test.rs
joshwlewis
approved these changes
May 23, 2024
This was referenced May 29, 2024
Merged
jplabadessa
pushed a commit
to jplabadessa/nodejs
that referenced
this pull request
Feb 28, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.2.3`. - Updated `heroku/nodejs-engine` to `3.2.3`. - Updated `heroku/nodejs-npm-engine` to `3.2.3`. - Updated `heroku/nodejs-npm-install` to `3.2.3`. - Updated `heroku/nodejs-pnpm-engine` to `3.2.3`. - Updated `heroku/nodejs-pnpm-install` to `3.2.3`. - Updated `heroku/nodejs-yarn` to `3.2.3`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine ### Added - 20.14.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.2.3`. - Updated `heroku/nodejs-function-invoker` to `3.2.3`. - Updated `heroku/nodejs-npm` to `3.2.3`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine - No changes. ## heroku/nodejs-npm-install - Fix for npm permission error when executing without root permissions ([#830](heroku/buildpacks-nodejs#830)) ## heroku/nodejs-pnpm-engine - No changes. ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a launch time layer that sets the following environment variables:
npm_config_cacheto write to a temporary directorylogs-dirtoo since it resides within the cache directorynpm_config-update-notifierto disable the update notifierCloses #800