Vendor buildpack-stdlib instead of fetching from S3#639
Merged
runesoerensen merged 7 commits intomainfrom Feb 18, 2026
Merged
Conversation
This also drops the `chmod a+x` bit, which isn't necessary as the file is only sourced
This version is identical to the one we downloaded from https://heroku-golang-prod.s3.us-east-1.amazonaws.com/stdlib.sh.v8, so prefer specifying the upstream source
Prefer using the upstream GitHub source to avoid the `lang-common` S3 bucket dependency
runesoerensen
changed the title
edmorley
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors
stdlib.sh.v8instead of fetching it from S3 on every build. See this related PR for more context: heroku/heroku-buildpack-python#1100.To drop the dependency on the
lang-commonS3 bucket, thefiles.jsoninventory was updated to use the upstream GitHub source URL instead.stdlib.sh.v8will continue to be available in the S3 mirror bucket and this allowsbin/sync-files.shto run without explicitly excluding it. That being said, we might want to just removestdlib.sh.v8fromfiles.json, and update themake synctarget accordingly - since it's no longer a required test asset, the file will only be downloaded from the source URL if someone tries to sync thefiles.jsoninventory to an S3 bucket that doesn't include it already (which is somewhat unlikely).GUS-W-13958531