Change curl timeout for low speed connection#605
Closed
saigontech wants to merge 1 commit intoheroku:mainfrom
Closed
Change curl timeout for low speed connection#605saigontech wants to merge 1 commit intoheroku:mainfrom
saigontech wants to merge 1 commit intoheroku:mainfrom
Conversation
edmorley
reviewed
Jan 15, 2024
Member
edmorley
left a comment
edmorley
left a comment
There was a problem hiding this comment.
(switching the code review request from the team alias to the PHP language owner)
Contributor
|
Idea: should we support |
Member
|
Fwiw for Python, bumping the fixed timeout very slightly was enough to make the "underpowered server" use-case work without needing to support customising the timeout: |
dzuelke
added a commit
that referenced
this pull request
Feb 20, 2024
To support environments where it takes longer than 5 seconds to establish the HTTPS connection (such as Dokku). Closes #605. GUS-W-15080665
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
) To support environments where it takes longer than 5 seconds to establish the HTTPS connection (such as Dokku). Closes heroku#605. GUS-W-15080665
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
) To support environments where it takes longer than 5 seconds to establish the HTTPS connection (such as Dokku). Closes heroku#605. GUS-W-15080665
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
) To support environments where it takes longer than 5 seconds to establish the HTTPS connection (such as Dokku). Closes heroku#605. GUS-W-15080665
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
) To support environments where it takes longer than 5 seconds to establish the HTTPS connection (such as Dokku). Closes heroku#605. GUS-W-15080665
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the low-speed connection environment, the current 5s timeout value seems too low.
I often get
Failed to download standard library for bootstrapping!error when deploying the app to my homelab servercan we increase it to ~ 60s to make it works more friendly?