Skip to content

Binary build script: Enable --with-system-expat #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
May 3, 2022
Merged

Binary build script: Enable --with-system-expat #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Use the `expat` package from the stack image rather than CPython's vendored version, when building
Python binaries ([#1319](https://github.com/heroku/heroku-buildpack-python/pull/1319)).

## v210 (2022-04-14)

Expand Down
3 changes: 3 additions & 0 deletions builds/runtimes/python
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ CONFIGURE_OPTS=(
# Skip running `ensurepip` as part of install, since the buildpack installs a curated
# version of pip itself (which ensures it's consistent across Python patch releases).
"--with-ensurepip=no"
# Build the `pyexpat` module using the `expat` library in the stack image (which will
# automatically receive security updates), rather than CPython's vendored version.
"--with-system-expat"
)

if [[ "${VERSION}" != 3.7.* ]]; then
Expand Down
⚡