Skip to content

Update pipenv version to 2022.11.30#1403

Closed
alex20465 wants to merge 1 commit intoheroku:mainfrom
WebrunnersGmbH:main
Closed

Update pipenv version to 2022.11.30#1403
alex20465 wants to merge 1 commit intoheroku:mainfrom
WebrunnersGmbH:main

Conversation

@alex20465
Copy link
Copy Markdown

Not much to describe, this is just a singleliner with the latest stable pipenv version.

@alex20465 alex20465 requested a review from a team as a code owner February 3, 2023 12:17
@edmorley
Copy link
Copy Markdown
Member

edmorley commented Feb 3, 2023

Hi! Thank you for the PR.

Updating to newer pipenv is on my list for next week. Several releases since the old 2020.11.15 version we're on have had regressions (which is why it hasn't been updated sooner) - but things are looking better with newer pipenv versions, so hopefully it's safe enough to try now.

The CI for this repo needs credentials to run, so I'll have to update this from a non-forked PR. (I'll also update the tests that need updating for this change at the same time.)

edmorley added a commit that referenced this pull request Feb 8, 2023
Copy link
Copy Markdown
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for the PR!

Closing this in favour of #1407 (since there is a newer pipenv available now, a few more changes were needed for tests etc + CI can't run from forks).

@edmorley edmorley closed this Feb 8, 2023
edmorley added a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants