Skip to content

Enable Bash exit on undefined variables (set -u)#1646

Merged
edmorley merged 1 commit intomainfrom
set-u
Sep 30, 2024
Merged

Enable Bash exit on undefined variables (set -u)#1646
edmorley merged 1 commit intomainfrom
set-u

Conversation

@edmorley
Copy link
Copy Markdown
Member

@edmorley edmorley commented Sep 30, 2024

Since it's a best practice that helps make bugs more visible - and that is now more viable after the earlier fixes in eg #1645.

Aside from the DEBUG_COLLECTSTATIC change/fix, all of the others only affect buildpack internals.

GUS-W-16864420.

@edmorley edmorley self-assigned this Sep 30, 2024
Since it's a best practice that helps make bugs more visible.

Aside from the `DEBUG_COLLECTSTATIC` change, all of the
others only affect buildpack internals.

GUS-W-16864420.
@edmorley edmorley marked this pull request as ready for review September 30, 2024 10:41
@edmorley edmorley requested a review from a team as a code owner September 30, 2024 10:41
@edmorley edmorley enabled auto-merge (squash) September 30, 2024 10:42
@edmorley edmorley added the bug label Sep 30, 2024
@edmorley edmorley merged commit 4a264fc into main Sep 30, 2024
@edmorley edmorley deleted the set-u branch September 30, 2024 15:11
@heroku-linguist heroku-linguist bot mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants