Skip to content

Deprecate using Pipenv without a lockfile #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
Nov 12, 2024
Merged

Deprecate using Pipenv without a lockfile #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Deprecated using Pipenv without a lockfile (`Pipfile.lock`). ([#1695](https://github.com/heroku/heroku-buildpack-python/pull/1695))

## [v266] - 2024-11-08

Expand Down
12 changes: 10 additions & 2 deletions lib/package_manager.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,19 @@ function package_manager::determine_package_manager() {
meta_set "pipenv_has_lockfile" "true"
elif [[ -f "${build_dir}/Pipfile" ]]; then
# TODO: Start requiring a Pipfile.lock and make this branch a "missing lockfile" error instead.
# TODO: Adjust this warning to mention support for missing Pipfile.lock will be removed soon.
output::warning <<-'EOF'
Warning: No 'Pipfile.lock' found!

We recommend you commit this into your repository.
A 'Pipfile' file was found, however, the associated 'Pipfile.lock'
Pipenv lockfile was not. This means your app dependency versions
are not pinned, which means the package versions used on Heroku
might not match those installed in other environments.

For now, we will install your dependencies without a lockfile,
however, in the future this warning will become an error.

Run 'pipenv lock' locally to generate the lockfile, and make sure
that 'Pipfile.lock' is not listed in '.gitignore' or '.slugignore'.
EOF
package_managers_found+=(pipenv)
package_managers_found_display_text+=("Pipfile (Pipenv)")
Expand Down
11 changes: 10 additions & 1 deletion spec/hatchet/pipenv_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,16 @@
remote:
remote: ! Warning: No 'Pipfile.lock' found!
remote: !
remote: ! We recommend you commit this into your repository.
remote: ! A 'Pipfile' file was found, however, the associated 'Pipfile.lock'
remote: ! Pipenv lockfile was not. This means your app dependency versions
remote: ! are not pinned, which means the package versions used on Heroku
remote: ! might not match those installed in other environments.
remote: !
remote: ! For now, we will install your dependencies without a lockfile,
remote: ! however, in the future this warning will become an error.
remote: !
remote: ! Run 'pipenv lock' locally to generate the lockfile, and make sure
remote: ! that 'Pipfile.lock' is not listed in '.gitignore' or '.slugignore'.
remote:
remote: -----> No Python version was specified. Using the buildpack default: Python #{DEFAULT_PYTHON_MAJOR_VERSION}
remote: To use a different version, see: https://devcenter.heroku.com/articles/python-runtimes
Expand Down
⚡