Skip to content

Fix Dev Center links to reflect recent article URL changes #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edmorley merged 1 commit into from
Dec 13, 2024
Merged

Fix Dev Center links to reflect recent article URL changes #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [Unreleased]

- Fixed Dev Center links to reflect recent article URL changes. ([#1723](https://github.com/heroku/heroku-buildpack-python/pull/1723))

## [v271] - 2024-12-12

Expand Down
1 change: 0 additions & 1 deletion bin/steps/nltk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,5 @@ if is_module_available 'nltk'; then
else
meta_set "nltk_downloader" "skipped-no-nltk-file"
echo " 'nltk.txt' not found, not downloading any corpora"
echo " Learn more: https://devcenter.heroku.com/articles/python-nltk"
fi
fi
2 changes: 1 addition & 1 deletion bin/steps/python
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if ! curl --output /dev/null --silent --head --fail --retry 3 --retry-connrefuse
Error: Python ${python_full_version} isn't available for this stack (${STACK}).

For a list of the supported Python versions, see:
https://devcenter.heroku.com/articles/python-support#supported-runtimes
https://devcenter.heroku.com/articles/python-support#supported-python-versions
EOF
meta_set "failure_reason" "python-version-not-found"
exit 1
Expand Down
11 changes: 6 additions & 5 deletions lib/python_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function python_version::resolve_python_version() {
${DEFAULT_PYTHON_MAJOR_VERSION}

For a list of the supported Python versions, see:
https://devcenter.heroku.com/articles/python-support#supported-runtimes
https://devcenter.heroku.com/articles/python-support#supported-python-versions
EOF
else
output::error <<-EOF
Expand All @@ -315,7 +315,7 @@ function python_version::resolve_python_version() {
version configured via the '${python_version_origin}' file.

For a list of the supported Python versions, see:
https://devcenter.heroku.com/articles/python-support#supported-runtimes
https://devcenter.heroku.com/articles/python-support#supported-python-versions
EOF
fi
meta_set "failure_reason" "python-version::eol"
Expand Down Expand Up @@ -347,11 +347,12 @@ function python_version::resolve_python_version() {
Check that this Python version has been officially released,
and that the Python buildpack has added support for it:
https://devguide.python.org/versions/#supported-versions
https://devcenter.heroku.com/articles/python-support#supported-runtimes
https://devcenter.heroku.com/articles/python-support#supported-python-versions

If it has, make sure that you are using the latest version
of this buildpack:
https://devcenter.heroku.com/articles/python-support#checking-the-python-buildpack-version
of this buildpack, and have not pinned to an older release:
https://devcenter.heroku.com/articles/managing-buildpacks#view-your-buildpacks
https://devcenter.heroku.com/articles/managing-buildpacks#classic-buildpacks-references

Otherwise, switch to a supported version (such as Python ${DEFAULT_PYTHON_MAJOR_VERSION})
by updating the version configured via the '${python_version_origin}' file.
Expand Down
1 change: 0 additions & 1 deletion spec/hatchet/nltk_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
expect(clean_output(app.output)).to match(Regexp.new(<<~REGEX))
remote: -----> Downloading NLTK corpora...
remote: 'nltk.txt' not found, not downloading any corpora
remote: Learn more: https://devcenter.heroku.com/articles/python-nltk
REGEX
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/hatchet/pipenv_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@
remote: ! version configured via the 'Pipfile.lock' file.
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion spec/hatchet/python_update_warning_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
remote: ! Error: Python 3.8.0 isn't available for this stack (#{app.stack}).
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand Down
15 changes: 8 additions & 7 deletions spec/hatchet/python_version_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
remote: ! Error: Python #{LATEST_PYTHON_3_8} isn't available for this stack (#{app.stack}).
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand Down Expand Up @@ -266,7 +266,7 @@
remote: ! version configured via the '.python-version' file.
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand All @@ -290,11 +290,12 @@
remote: ! Check that this Python version has been officially released,
remote: ! and that the Python buildpack has added support for it:
remote: ! https://devguide.python.org/versions/#supported-versions
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote: !
remote: ! If it has, make sure that you are using the latest version
remote: ! of this buildpack:
remote: ! https://devcenter.heroku.com/articles/python-support#checking-the-python-buildpack-version
remote: ! of this buildpack, and have not pinned to an older release:
remote: ! https://devcenter.heroku.com/articles/managing-buildpacks#view-your-buildpacks
remote: ! https://devcenter.heroku.com/articles/managing-buildpacks#classic-buildpacks-references
remote: !
remote: ! Otherwise, switch to a supported version (such as Python #{DEFAULT_PYTHON_MAJOR_VERSION})
remote: ! by updating the version configured via the '.python-version' file.
Expand All @@ -317,7 +318,7 @@
remote: ! Error: Python 3.12.999 isn't available for this stack (#{app.stack}).
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand Down Expand Up @@ -378,7 +379,7 @@
remote: ! version configured via the 'runtime.txt' file.
remote: !
remote: ! For a list of the supported Python versions, see:
remote: ! https://devcenter.heroku.com/articles/python-support#supported-runtimes
remote: ! https://devcenter.heroku.com/articles/python-support#supported-python-versions
remote:
remote: ! Push rejected, failed to compile Python app.
OUTPUT
Expand Down
⚡