Skip to content

Remove support for Heroku-20#1778

Merged
edmorley merged 1 commit intomainfrom
rm-heroku-20
May 1, 2025
Merged

Remove support for Heroku-20#1778
edmorley merged 1 commit intomainfrom
rm-heroku-20

Conversation

@edmorley
Copy link
Copy Markdown
Member

@edmorley edmorley commented May 1, 2025

Since the Heroku-20 stack has reached end-of-life, and as such builds using it are no longer supported by the Heroku build system: https://devcenter.heroku.com/changelog-items/3230

This fixes the integration tests failing in CI for the Heroku-20 stack, due to the build system now (as expected) rejecting the jobs.

Any non-Heroku consumers of this buildpack that wish to continue using the Heroku-20 stack should pin to the previous version of this buildpack.

GUS-W-14707057.

Since the Heroku-20 stack has reached end-of-life, and as such builds
using it are no longer supported by the Heroku build system:
https://devcenter.heroku.com/changelog-items/3230

This fixes the integration tests failing in CI for the Heroku-20 stack,
due to the build system now (as expected) rejecting the jobs.

Any non-Heroku consumers of this buildpack that wish to continue using
the Heroku-20 stack should pin to the previous version of this
buildpack.

GUS-W-14707057.
@edmorley edmorley self-assigned this May 1, 2025
@edmorley edmorley marked this pull request as ready for review May 1, 2025 14:01
@edmorley edmorley requested a review from a team as a code owner May 1, 2025 14:01
@edmorley edmorley enabled auto-merge (squash) May 1, 2025 14:55
@edmorley edmorley merged commit ba7a7e3 into main May 1, 2025
6 checks passed
@edmorley edmorley deleted the rm-heroku-20 branch May 1, 2025 16:07
@heroku-linguist heroku-linguist bot mentioned this pull request May 2, 2025
edmorley added a commit that referenced this pull request Aug 6, 2025
The `heroku-20` entry was removed completely in #1778
rather than moving it to the EOL branch of the conditional,
causing the "stack not recognised" message variant to be
shown, instead of the "stack no longer supported" version.

This error messages can never occur on Heroku (since our
build system can only scheduled builds for supported stacks),
but these cases can be hit for non-Heroku uses of this
buildpack (such as Dokku).

GUS-W-19274871.
edmorley added a commit that referenced this pull request Aug 6, 2025
The `heroku-20` entry was removed completely in #1778
rather than moving it to the EOL branch of the conditional,
causing the "stack not recognised" message variant to be
shown, instead of the "stack no longer supported" version.

This error messages can never occur on Heroku (since our
build system can only scheduled builds for supported stacks),
but these cases can be hit for non-Heroku uses of this
buildpack (such as Dokku).

GUS-W-19274871.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants