use pkg_resources to check for distributions#395
Merged
kennethreitz merged 1 commit intoheroku:masterfrom May 30, 2017
davidism:pip-grep
Merged
use pkg_resources to check for distributions#395kennethreitz merged 1 commit intoheroku:masterfrom davidism:pip-grep
kennethreitz merged 1 commit intoheroku:masterfrom
davidism:pip-grep
Conversation
more accurate than parsing requirements.txt fixes #359
Contributor
|
✨🍰✨ |
kennethreitz
added a commit
that referenced
this pull request
Jun 2, 2017
This reverts commit 9b185f9.
kennethreitz
added a commit
that referenced
this pull request
Jun 2, 2017
oTree-org
pushed a commit
to oTree-org/oTree
that referenced
this pull request
Dec 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the implementation of
pip-grepto usepkg_resources.get_distributioninstead of parsingrequirements.txtmanually. This makes the buildpack more accurate for some project configurations.This change is backwards compatible, scripts calling this with a requirements file will continue to work, since "requirements.txt" is not a package.
fixes #359