Conversation
SukkaW
approved these changes
Sep 4, 2019
Contributor
|
I just ran your last change with --fix on hexojs/hexo master and got: 97 files changes :) That is a lot of changes |
Contributor
Author
|
I propose |
Contributor
Author
|
Pending #25, if that is approved, this PR needs to remove some conflicting rules. |
Contributor
Author
|
Reverted one-var rule as it's not related to es6. |
tomap
approved these changes
Sep 15, 2019
Contributor
Author
|
suggest to hold off merging for now, let's refactor hexo first to see if this PR is actually viable. |
This was referenced Oct 2, 2019
Contributor
Author
|
Pending hexojs/hexo#3717 |
Contributor
Author
|
Refactored hexo:
I'm merging this since this PR is viable. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

based on eslint-config-airbnb.