feat: revert lazy-loaded image attributes#273
Open
moon-jam wants to merge 1 commit intohexojs:masterfrom
Open
Conversation
data-src to src in feed content and descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data-src to src in feed content and descriptions
check list
Description
Many Hexo themes use front-end lazy-loading libraries (e.g.,
tuupola/lazyload), which replace the imagesrcwith a placeholder and move the actual URL todata-src. Since RSS readers don't execute JavaScript, these images appear broken in feeds.This PR fixes this by reverting lazy-loaded attributes in the feed output:
data-src(as well asdata-srcsetanddata-sizes) back to standardsrc/srcset/sizes.src.This ensures images render correctly in RSS/Atom readers while keeping lazy-load intact on the blog itself.
Additional information
I'm completely open to feedback on this! If you think this reverting behavior should be implemented as an optional feature instead of a default (e.g., controlled via a configuration flag like
feed.revert_lazyload: true), please let me know and I'll be more than happy to update the PR accordingly!