Use old language file selection when no default file exists#3110
Merged
JLHwung merged 1 commit intohexojs:masterfrom Apr 6, 2018
bobd91:default-language
Merged
Use old language file selection when no default file exists#3110JLHwung merged 1 commit intohexojs:masterfrom bobd91:default-language
JLHwung merged 1 commit intohexojs:masterfrom
bobd91:default-language
Conversation
|
Thank's. Looks better. 👍 |
ivan-nginx
approved these changes
Apr 6, 2018
JLHwung
approved these changes
Apr 6, 2018
Collaborator
|
Will land in next patch release. Thanks. |
ivan-nginx
added a commit
to theme-next/hexo-theme-next
that referenced
this pull request
Apr 9, 2018
After complete fix with language file selection in Hexo we can use old method with no bugs. Issue: hexojs/hexo#3108 Fix 1: hexojs/hexo#3069 Fix 2: hexojs/hexo#3110
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3108 points out that many existing themes rely on the old but incorrect way of selecting language files prior to the pull request #3069 which fixes the incorrect behaviour.
This PR makes a small change so that when no language is configured and no default language file exists then the fallback is to use the old method of selecting a language file rather than not selecting any file.
A single test has been added to confirm that the first language file added will be used as the fallback.