feat(permalink): pretty_urls.trailing_html#3893
Closed
curbengh wants to merge 2 commits intohexojs:masterfrom
Closed
feat(permalink): pretty_urls.trailing_html#3893curbengh wants to merge 2 commits intohexojs:masterfrom
curbengh wants to merge 2 commits intohexojs:masterfrom
Conversation
1 task
SukkaW
approved these changes
Nov 30, 2019
Member
|
Since codeclimate detects too many duplicated code blocks, we could bring up a |
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Continuation of #3691
When
pretty_urls.trailing_htmlis disabled, permalink likeexample.com/foo/bar.htmlis transformed intoexample.com/foo/bar/. Trailing slash is appended for now,pretty_urls.trailing_slashcan be introduced in later PR.The option doesn't apply to url with trailing
index.html, e.g.example.com/foo/bar/index.html. I don't thinkexample.com/foo/bar/index/is valid.How to test
Screenshots
Pull request tasks