Mega cleanup: #413, #416, #418, #419 (close #399)

[dsarno]

Summary

Bundle four contained backlog fixes into a single PR against beta. None touch the self-update install/extract/enable path; runner behavior is unchanged in production (changes there are test-mode-only).

Issue	What changes	Risk
#419 — diag script	script/local-game-capture-diag: split in-memory vs on-disk autoload detection, fix HINT suppression bugs, ignore comment-prefixed and value-substring matches	none (script-only)
#413 — test noise	Add _suppress_scan_warnings opt-out on update_reload_runner; tests set it via _arm_scan_state, production default stays false	low (no production behavior change)
#418 — auto-spawn	start_server walks up to a sibling src/godot_ai/ and prepends to PYTHONPATH, gated on is_dev_checkout()	low (production user installs unchanged)
#416 — banner detail	/godot-ai/status adds package_path; dock incompatible-server message surfaces "(loaded from <path>)" when present	low (cosmetic + a new server field)
#399 — closed	Closed as not-planned — see the closing comment for the three-layer rationale	n/a

Details

#419 — local-game-capture-diag autoload-missing diagnostic

The HINT line was suppressed in two real failure shapes and the FAIL bullet list contradicted the prior autoload registered=True line:

• Bug 1: commented-out lines (;_mcp_game_helper=…) tripped the substring match, so the HINT didn't print when the autoload was disabled on disk.
• Bug 2: a single found bool OR'd in-memory presence with on-disk presence, so the in-memory-only case (autoload registered in editor but missing from project.godot) silently suppressed the HINT — even though that's exactly the case where the game subprocess won't see it.
• Bug 3: when the bridge failed, the bullet list said "autoload missing from project.godot (see above)" immediately after printing autoload registered=True, which read as contradictory.

Fix: split into {"in_memory": bool, "on_disk": bool}, emit three different HINTs keyed to the split state, skip comment-prefixed lines, match on the autoload key (not the value).

#413 — push_warning noise from update_reload_runner tests

Two of the watchdog unit tests directly invoke _on_scan_watchdog_timeout and the post-timeout-bypass branch of _start_filesystem_scan to pin their behavior. Both code paths emit push_warning lines that surface as yellow noise three times per test_run, training reviewers to ignore the runner's real production warnings.

Fix: add _suppress_scan_warnings (default false). _arm_scan_state in the test fixture flips it true so the tested code paths stay quiet without losing assertion coverage. New regression test test_suppress_scan_warnings_default_is_off pins the production default so a future refactor can't quietly turn off the user-facing warning.

Verified live: zero filesystem_changed warnings across all 1257 GDScript tests after the change.

#418 — auto-spawn ignores worktree src/ in dev checkouts

plugin.gd::start_dev_server already walks up from res:// to find a sibling src/godot_ai/ and prepends it to PYTHONPATH so a worktree serves its own Python rather than the root repo's editable install. The auto-spawn path in server_lifecycle.gd::start_server didn't — so worktrees with different pyproject.toml versions than the root would loop in "Incompatible server / Restart Server" forever (as described in the issue's repro: root on 1.4.4, worktree on 2.4.2, server reports 1.4.4, plugin flags incompatible, Restart Server respawns the same incompatible server).

Fix: mirror the dev-server walk-up in start_server, gated on is_dev_checkout() so production user installs are byte-for-byte unchanged. Restore PYTHONPATH immediately after OS.create_process returns to avoid leaking the env to unrelated spawns.

#416 — incompatible-server banner omits running server's load path

Add package_path (the resolved godot_ai/__init__.py parent dir) to /godot-ai/status. The editor's _probe_live_server_status captures it, and _incompatible_server_message appends (loaded from <path>) when the field is present and the peer identifies as godot-ai. Degrades cleanly:

• Pre-v2.4.4 servers omit the field → no empty (loaded from ) stub
• Non-godot-ai peer that happens to return a package_path JSON field → not surfaced; we won't mislabel an unrelated server as "godot-ai loaded from …"

#399 — closed as not-planned

See the closing comment on the issue. tl;dr: the proposed class_name retirement shipped in v2.4.1 and triggered the exact 500+ error cascade it was meant to prevent, v2.4.2 restored the shim, and the underlying parse-hazard is now fixed at the runner via single-phase write-before-scan (#398, #415). The 306-violation ratchet has been replaced with behavioral pins.

Test plan

• ruff check src/ tests/ — clean
• ruff format --check src/ tests/ — clean
• pytest — 908 passed, 2 skipped (pre-existing skips)
• Godot test_run (headless) — 1240/1257 passed, 0 failed, 17 skipped (display-dependent suites)
• plugin_lifecycle suite — 67/67 (4 new tests for Dock "Incompatible server" warning omits running version + load path — every skew incident requires manual process inspection #416)
• update_reload_runner suite — 16/16 (1 new test for test_update_reload_runner burns 30–60s waiting for filesystem_changed signal that can't fire (fixture is outside res://) #413)
• test_server_status.py — 2/2 (1 new test for Dock "Incompatible server" warning omits running version + load path — every skew incident requires manual process inspection #416)
• Verified live editor log: zero filesystem_changed didn't fire warnings from the runner across the full GDScript suite (was 3 per test_run pre-fix)
• Cross-platform smoke (Windows/macOS) — relies on CI

---

Generated by Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR bundles several small fixes across the Godot plugin, Python server, tests, and a local diagnostic script to improve developer ergonomics and reduce confusion in multi-worktree setups, while keeping production behavior unchanged (notably: scan-warning suppression is test-only, and worktree PYTHONPATH handling is gated to dev checkouts).

Changes:

• Add package_path to /godot-ai/status, plumb it through the plugin probe, and surface it in the “Incompatible server” banner (with regression tests).
• Silence scan-watchdog push_warning noise during update_reload_runner unit tests via a new test-only suppression flag (with a default-off invariant test).
• Improve script/local-game-capture-diag autoload diagnostics by splitting in-memory vs on-disk detection and fixing comment/key matching.
• In dev checkouts, auto-spawn now prepends the worktree src/ to PYTHONPATH for the spawned server, then immediately restores PYTHONPATH.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/godot_ai/server.py	Adds package_path to /godot-ai/status so the editor can diagnose which Python package directory is serving a port.
plugin/addons/godot_ai/plugin.gd	Captures package_path from the status probe into the plugin’s live-server snapshot.
plugin/addons/godot_ai/utils/server_lifecycle.gd	Surfaces (loaded from <path>) in incompatible-server messages and prepends worktree src/ to PYTHONPATH for dev-checkout auto-spawn (with env restore).
plugin/addons/godot_ai/update_reload_runner.gd	Adds _suppress_scan_warnings to suppress watchdog warnings in tests while keeping production defaults unchanged.
test_project/tests/test_plugin_lifecycle.gd	Adds coverage for banner formatting with/without package_path and for non-godot-ai peers.
test_project/tests/test_update_reload_runner.gd	Sets _suppress_scan_warnings in the test fixture and pins the default to “off” for production runners.
tests/unit/test_server_status.py	Extends status-route expectations and adds an invariant test ensuring package_path points at a real loaded package dir.
script/local-game-capture-diag	Fixes autoload HINT suppression by tracking in-memory vs on-disk state, skipping comment-prefixed lines, and matching on the autoload key.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.