Eliminate benign Logger parse errors on Godot < 4.5 (#475 follow-up)

[dsarno]

Summary

runtime/editor_logger.gd and runtime/game_logger.gd extends Logger (a Godot 4.5+ class). Godot's editor filesystem scan parses every .gd under the project, so on 4.3/4.4 each file printed a Parse Error: Could not find base class "Logger" (+ a "Failed to load script" follow-up) on every editor startup. Functionally harmless (the scripts are only instanced behind a ClassDB.class_exists("Logger") gate), but real red error text we shouldn't ship to 4.3 users.

Fix: move both files into runtime/loggers/, which carries a .gdignore so Godot's editor scan skips the folder entirely — no parse, no error, on any engine. A new plain-RefCounted runtime/logger_loader.gd (parses on every version) compiles them from on-disk source via FileAccess + GDScript.new() at runtime (FileAccess is unaffected by .gdignore, which only governs the resource importer). plugin.gd and game_helper.gd call LoggerLoader.build(...) past their existing ClassDB.class_exists("Logger") gate, so the extends Logger parse only ever happens on 4.5+ where it resolves.

Also drops the now-moot ALLOW_LOGGER_PARSE_ERRORS filter (added in #478) from ci-check-gdscript + ci.yml: with the errors gone, the GDScript check is strict on every engine again — a real Logger error now fails CI on any version, including the 4.3 canary.

Verification (both engines)

• Godot 4.3: godot --headless --import + strict ci-check-gdscript → ZERO parse errors (the two Logger lines are gone). This is the whole point.
• Godot 4.6: same strict check passes; editor log-capture suite 18/18 green (12 editor_logger + 6 game_logger) — the runtime source-build loader yields a working Logger subclass with functioning virtuals + static helpers; full editor suite 91 pass / 0 fail.
• test_editor.gd logger tests switched from load(<path>) to LoggerLoader.build(<path>) (a .gdignore'd path can't be load()-ed).
• ruff clean (no Python touched).

Notes

• Exported games: .gdignore'd files are excluded from export packs, so LoggerLoader.build() returns null there (file absent) and log capture is simply unavailable — which is correct, since there's no editor/MCP attached to an exported game. The gate + null-check handle it gracefully.
• Pairs with Gate in-editor self-update off on Godot < 4.4 (#475) #482 (the < 4.4 self-update gate). Both should land before v2.5.8 so 4.3 users get a fully clean experience: plugin loads, no error lines, and the Update button routes to a manual-download page instead of crashing.

Test plan

• 4.3 strict import check: zero parse errors
• 4.6 strict import check: zero parse errors
• 4.6 logger suite 18/18; full editor suite 91/0
• ruff clean
• CI green across Linux (4.6.2 + 4.3 canary) / macOS / Windows

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR eliminates noisy-but-benign extends Logger parse errors on Godot < 4.5 by preventing the editor filesystem scan from parsing the Logger subclasses, while still allowing them to be instantiated at runtime on Godot 4.5+.

Changes:

• Move editor_logger.gd / game_logger.gd under a .gdignore’d runtime/loggers/ folder to avoid editor-scan parsing on older Godot versions.
• Add runtime/logger_loader.gd to compile the ignored logger scripts from on-disk source via FileAccess + GDScript.new() (only after the existing ClassDB.class_exists("Logger") gate).
• Remove the CI allowlist for Logger parse errors, restoring strict ci-check-gdscript behavior on all engine versions and updating docs/tests accordingly.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit/test_game_logger_no_class_name_lookup.py	Updates the on-disk path used by the unit test to the new runtime/loggers/ location.
test_project/tests/test_editor.gd	Switches logger tests from load(path) to LoggerLoader.build(path) for .gdignore’d scripts.
script/ci-check-gdscript	Removes the Logger-specific filter and makes parse-error detection strict again on all versions.
plugin/addons/godot_ai/runtime/loggers/game_logger.gd	Relocates game logger and updates header comments for the new .gdignore + loader model.
plugin/addons/godot_ai/runtime/loggers/editor_logger.gd	Relocates editor logger; adds path-based preload for log backtrace resolution.
plugin/addons/godot_ai/runtime/loggers/.gdignore	Ensures the runtime/loggers/ folder is skipped by the editor filesystem scan.
plugin/addons/godot_ai/runtime/logger_loader.gd	New runtime compiler for .gdignore’d logger scripts.
plugin/addons/godot_ai/runtime/logger_loader.gd.uid	UID for the new loader script.
plugin/addons/godot_ai/runtime/game_helper.gd	Uses LoggerLoader.build(...) to attach the game logger at runtime.
plugin/addons/godot_ai/plugin.gd	Uses LoggerLoader.build(...) for the editor logger; adds one-time cleanup for legacy logger scripts after self-update.
docs/testing-strategy.md	Documents that GDScript validation is strict again on all versions.
docs/plugin-architecture.md	Updates the runtime layout documentation to include logger_loader.gd and runtime/loggers/.
CLAUDE.md	Updates version-compat guidance to reflect .gdignore + runtime compilation for Logger scripts.
.github/workflows/ci.yml	Removes ALLOW_LOGGER_PARSE_ERRORS env wiring for the 4.3 canary row.
.claude/skills/godot-ai/skill.md	Updates CI guidance, but still contains an outdated later bullet that needs alignment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[dsarno]

Fixed in af1ef8e — docstring example now points at runtime/loggers/game_logger.gd.

[dsarno]

Fixed in af1ef8e — rewrote the GDScript-conventions extends-Logger bullet to describe the .gdignore + logger_loader runtime-build (no parse error on any version) and dropped the old runtime/*.gd paths + ALLOW_LOGGER_PARSE_ERRORS.