Simplify batch_handler#7
Merged
Merged
Conversation
- Read failure error from results list instead of a redundant local - Drop dead INVALID_HISTORY guard in _capture_histories (only called after a successful commit, so the history always exists) - Tighten the histories comment to the non-obvious Godot constraint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
results[-1]["error"]instead of a redundant localINVALID_HISTORYguard in_capture_histories(only called after a successful commit, so the history always exists)historiescomment to just the non-obvious Godot constraintTest plan
pytest -v— 277 passedrun_tests suite=batch— 12/12 passed in live editor🤖 Generated with Claude Code