Change coverage percentage calculation for zero cases#1
Open
shannon wants to merge 2 commits intohiddentao:mainfrom
Open
Change coverage percentage calculation for zero cases#1shannon wants to merge 2 commits intohiddentao:mainfrom
shannon wants to merge 2 commits intohiddentao:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I may have a module that does not contain any functions. A constants file, or a module that re-exports other modules, or simply a file that only has top level logic. When this happens the functions is 0/0 but the percentage covered is 0%. I think it may make more sense to set the percentage to 100% when the total is 0.
I changed all of them just to keep it consistent but I can't imagine a scenario where there would be 0 lines or 0 branches.
This seems the simplest way to avoid the red 0% on files that don't contain any functions.