feat: Improve blockIsEnding and shutdown of Publisher#2505
Open
feat: Improve blockIsEnding and shutdown of Publisher#2505
blockIsEnding and shutdown of Publisher#2505Conversation
ata-nas
added
the
pull request
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Complexity | 1 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
TIP This summary will be updated as you push new changes. Give us feedback
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
6 times, most recently
from
52d965f to
833b149
Compare
ata-nas
requested review from
AlfredoG87,
Nana-EC,
berryware,
ivannov and
rockysingh
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
2 times, most recently
from
c5cfe40 to
ba3e845
Compare
Contributor
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Apologies for the delay reviewing this.
There are a few areas where we can make some significant improvements.
...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Show resolved
Hide resolved
...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Show resolved
Hide resolved
...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Show resolved
Hide resolved
...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Show resolved
Hide resolved
...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java
Show resolved
Hide resolved
...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java
Outdated
Show resolved
Hide resolved
...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java
Outdated
Show resolved
Hide resolved
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
from
ba3e845 to
0e12892
Compare
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
from
862bf61 to
e1f4e6a
Compare
* Centralized publisher request results * Improvements for shutdown * Manager schedules shutdowns instead of forcing them * Send SKIP instead of END_ERROR in `getActionForCurrentlyStreaming` * Receiving an EndOfBlock for block the manager no longer needs still allows a RESEND to possibly be sent as a response Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
from
e1f4e6a to
073dbda
Compare
Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
2 times, most recently
from
5e73c3a to
7a1c3dd
Compare
Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
ata-nas
force-pushed
the
2344-improve-blockisending-and-shutdown-of-publisher
branch
from
7a1c3dd to
ed9e5b0
Compare
...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java
Outdated
Show resolved
Hide resolved
...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2505 +/- ##
============================================
- Coverage 81.32% 81.23% -0.09%
+ Complexity 1509 1508 -1
============================================
Files 139 139
Lines 7131 7157 +26
Branches 754 749 -5
============================================
+ Hits 5799 5814 +15
- Misses 1008 1018 +10
- Partials 324 325 +1
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
jsync-swirlds
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
getActionForCurrentlyStreamingRelated Issue(s)
Closes #1949
Closes #2344
Closes #2339