feat(1654): Claim airdrop command implementation#1784
Open
Conversation
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
mmyslblocky
requested changes
Apr 10, 2026
Comment on lines
+176
to
+198
| private resolveAccountId( | ||
| accountOrAlias: string, | ||
| api: CoreApi, | ||
| network: SupportedNetwork, | ||
| ): string { | ||
| const resolved = api.alias.resolve( | ||
| accountOrAlias, | ||
| AliasType.Account, | ||
| network, | ||
| ); | ||
| if (resolved?.entityId) { | ||
| return resolved.entityId; | ||
| } | ||
|
|
||
| const parsed = EntityIdSchema.safeParse(accountOrAlias); | ||
| if (!parsed.success) { | ||
| throw new NotFoundError( | ||
| `Account not found with ID or alias: ${accountOrAlias}`, | ||
| ); | ||
| } | ||
|
|
||
| return parsed.data; | ||
| } |
Contributor
There was a problem hiding this comment.
check if IdentityResolutionService with AccountReferenceObjectSchema in the input.ts file can be used to to resolve account
Comment on lines
+216
to
+226
| private buildClaimItem( | ||
| item: TokenAirdropItem, | ||
| receiverAccountId: string, | ||
| ): ClaimAirdropItem { | ||
| return { | ||
| tokenId: item.token_id, | ||
| senderAccountId: item.sender_id, | ||
| receiverAccountId, | ||
| serialNumber: item.serial_number ?? undefined, | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
do we really need to move this lofic it to separate method
| } | ||
|
|
||
| private async fetchTokenInfoMap( | ||
| api: CoreApi, |
Contributor
There was a problem hiding this comment.
you can just pass the service you are using so in that case mirror service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1654