Skip to content

Clean up testDir in swirlds-benchmarks #24917

@thenswan

Description

@thenswan

BaseBench maintains a per-invocation testDir with setTestDir() / getTestDir() / preserveTestDir(),
but only 3 out of 7 benchmark classes actually use it meaningfully:

  • DataFileCollectionBench.compaction() — passes getTestDir() to DataFileCollection
  • HalfDiskMapBench.merge() — passes getTestDir() to HalfDiskHashMap
  • KeyValueStoreBench.merge() — passes getTestDir() to MemoryIndexDiskKeyValueStore

The remaining benchmarks (VirtualMapBench, CryptoBench, ReconnectBench) call setTestDir(...) but
never call getTestDir().

Metadata

Metadata

Assignees

Labels

PlatformTickets pertaining to the platform

Type

No fields configured for Task.

Projects

Status

👀 In Review

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions