Skip to content

chore: revamp the default configuration variables (#4785)#4792

Merged
jasuwienas merged 3 commits intomainfrom
4785-redefine-the-default-relay-configuration-to-improve-developer-experience
Apr 7, 2026
Merged

chore: revamp the default configuration variables (#4785)#4792
jasuwienas merged 3 commits intomainfrom
4785-redefine-the-default-relay-configuration-to-improve-developer-experience

Conversation

@jasuwienas
Copy link
Copy Markdown
Contributor

@jasuwienas jasuwienas commented Jan 12, 2026

Description

BREAKING CHANGE
Step 1 of adjusting the configuration: preset different default values to better match the behavior of other engines such as Geth and Besu.

Related issue(s)

Fixes #4785

Testing Guide

Changes from original design (optional)

This is a breaking change. All operators using our application must be notified. Please proceed with caution before including it in a release.

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@jasuwienas jasuwienas self-assigned this Jan 12, 2026
@jasuwienas jasuwienas added the enhancement New feature or request label Jan 12, 2026
@jasuwienas jasuwienas added this to the 0.75.0 milestone Jan 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 60834ee. ± Comparison against base commit a35fc2b.

♻️ This comment has been updated with latest results.

@jasuwienas jasuwienas marked this pull request as ready for review January 13, 2026 08:31
@jasuwienas jasuwienas requested review from a team as code owners January 13, 2026 08:31
@hiero-ledger hiero-ledger deleted a comment from silkshjasuwienas Jan 13, 2026
@jasuwienas jasuwienas force-pushed the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch from db374d3 to 69fb65e Compare January 13, 2026 15:32
Copy link
Copy Markdown
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean work! LGTM but some tests are failing

@jasuwienas
Copy link
Copy Markdown
Contributor Author

Flaky, restarted them, so they passed this time.

quiet-node
quiet-node previously approved these changes Jan 13, 2026
Copy link
Copy Markdown
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@jasuwienas jasuwienas force-pushed the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch from 69fb65e to d478e17 Compare January 15, 2026 07:15
@jasuwienas jasuwienas requested a review from quiet-node January 15, 2026 07:15
@jasuwienas jasuwienas force-pushed the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch from d478e17 to 8db5049 Compare January 15, 2026 07:20
quiet-node
quiet-node previously approved these changes Jan 15, 2026
Copy link
Copy Markdown
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rbarker-dev
rbarker-dev previously approved these changes Jan 16, 2026
@simzzz simzzz modified the milestones: 0.75.0, 0.76.0 Feb 16, 2026
@jasuwienas jasuwienas added blocked This is blocked by another item paused Blocked, but not necessarily by external teams and removed blocked This is blocked by another item labels Mar 18, 2026
@simzzz simzzz modified the milestones: 0.76.0, 0.77.0 Mar 24, 2026
@jasuwienas jasuwienas dismissed stale reviews from rbarker-dev and quiet-node via 244ff02 April 2, 2026 07:58
@jasuwienas jasuwienas force-pushed the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch 2 times, most recently from 244ff02 to 0909e42 Compare April 2, 2026 08:05
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 2, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

simzzz
simzzz previously approved these changes Apr 2, 2026
natanasow
natanasow previously approved these changes Apr 2, 2026
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
@jasuwienas jasuwienas dismissed stale reviews from natanasow and simzzz via 60834ee April 2, 2026 10:56
@jasuwienas jasuwienas force-pushed the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch from f95c120 to 60834ee Compare April 2, 2026 10:56
@jasuwienas jasuwienas requested a review from simzzz April 2, 2026 10:57
@jasuwienas jasuwienas changed the title chore: revamp the default configuration variables (#4785) [breaking change!] chore: revamp the default configuration variables (#4785) Apr 7, 2026
@jasuwienas jasuwienas removed the paused Blocked, but not necessarily by external teams label Apr 7, 2026
@jasuwienas jasuwienas merged commit c95f3f9 into main Apr 7, 2026
94 of 99 checks passed
@jasuwienas jasuwienas deleted the 4785-redefine-the-default-relay-configuration-to-improve-developer-experience branch April 7, 2026 08:47
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4792      +/-   ##
==========================================
+ Coverage   95.89%   95.90%   +0.01%     
==========================================
  Files         146      146              
  Lines       25114    25114              
  Branches     2032     2028       -4     
==========================================
+ Hits        24083    24086       +3     
+ Misses       1009     1006       -3     
  Partials       22       22              
Files with missing lines Coverage Δ
src/config-service/services/globalConfig.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bootcodes pushed a commit to bootcodes/hiero-json-rpc-relay that referenced this pull request Apr 10, 2026
…hiero-ledger#4792)

Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redefine the default Relay configuration to improve Developer Experience

6 participants