chore: revamp the default configuration variables (#4785)#4792
Merged
jasuwienas merged 3 commits intomainfrom Apr 7, 2026
Merged
Conversation
db374d3 to
69fb65e
Compare
quiet-node
reviewed
Jan 13, 2026
Contributor
quiet-node
left a comment
There was a problem hiding this comment.
Clean work! LGTM but some tests are failing
Contributor
Author
|
Flaky, restarted them, so they passed this time. |
69fb65e to
d478e17
Compare
d478e17 to
8db5049
Compare
quiet-node
reviewed
Jan 15, 2026
quiet-node
reviewed
Jan 15, 2026
rbarker-dev
approved these changes
Jan 15, 2026
rbarker-dev
approved these changes
Jan 15, 2026
rbarker-dev
previously approved these changes
Jan 16, 2026
244ff02 to
0909e42
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
simzzz
previously approved these changes
Apr 2, 2026
natanasow
previously approved these changes
Apr 2, 2026
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com>
f95c120 to
60834ee
Compare
simzzz
approved these changes
Apr 2, 2026
natanasow
approved these changes
Apr 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4792 +/- ##
==========================================
+ Coverage 95.89% 95.90% +0.01%
==========================================
Files 146 146
Lines 25114 25114
Branches 2032 2028 -4
==========================================
+ Hits 24083 24086 +3
+ Misses 1009 1006 -3
Partials 22 22
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bootcodes
pushed a commit
to bootcodes/hiero-json-rpc-relay
that referenced
this pull request
Apr 10, 2026
…hiero-ledger#4792) Signed-off-by: Mariusz Jasuwienas <jasuwienas@gmail.com> Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE
Step 1 of adjusting the configuration: preset different default values to better match the behavior of other engines such as Geth and Besu.
Related issue(s)
Fixes #4785
Testing Guide
Changes from original design (optional)
This is a breaking change. All operators using our application must be notified. Please proceed with caution before including it in a release.
Additional work needed (optional)
N/A
Checklist