perf: optimize getBlockTransactionDetails()#5224
Open
bootcodes wants to merge 4 commits intohiero-ledger:mainfrom
Open
perf: optimize getBlockTransactionDetails()#5224bootcodes wants to merge 4 commits intohiero-ledger:mainfrom
bootcodes wants to merge 4 commits intohiero-ledger:mainfrom
Conversation
Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
BartoszSolkaBD
approved these changes
Apr 7, 2026
Co-authored-by: jasuwienas <mariusz@jasuwienas.pl> Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
quiet-node
reviewed
Apr 9, 2026
Contributor
quiet-node
left a comment
quiet-node
left a comment
There was a problem hiding this comment.
LG just two small items
Signed-off-by: Thomas Boot <thomas.boot@swirldslabs.com>
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (71.16%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
@@ Coverage Diff @@
## main #5224 +/- ##
===========================================
- Coverage 95.92% 71.16% -24.77%
===========================================
Files 146 146
Lines 25182 25184 +2
Branches 2051 741 -1310
===========================================
- Hits 24157 17921 -6236
- Misses 1002 7245 +6243
+ Partials 23 18 -5
... and 89 files with indirect coverage changes 🚀 New features to boost your workflow:
|
BartoszSolkaBD
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix to improve the performance bottleneck from O(N^2) complexity to O(N) for
getBlockTransactionDetails()method insrc/relay/lib/debug.tsRelated issue(s)
Fixes #4904
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist